linux-kernel - Re: [PATCH v2 09/28] binder: keep vma addresses type as unsigned long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231204115659.40228-1-aliceryhl@google.com>
Date:   Mon,  4 Dec 2023 11:56:59 +0000
From:   Alice Ryhl <aliceryhl@...gle.com>
To:     cmllamas@...gle.com
Cc:     arve@...roid.com, brauner@...nel.org, gregkh@...uxfoundation.org,
        joel@...lfernandes.org, kernel-team@...roid.com,
        linux-kernel@...r.kernel.org, maco@...roid.com, surenb@...gle.com,
        tkjos@...roid.com, Alice Ryhl <aliceryhl@...gle.com>
Subject: Re: [PATCH v2 09/28] binder: keep vma addresses type as unsigned long

> The vma addresses in binder are currently stored as void __user *. This
> requires casting back and forth between the mm/ api which uses unsigned
> long. Since we also do internal arithmetic on these addresses we end up
> having to cast them _again_ to an integer type.
> 
> Lets stop all the unnecessary casting which kills code readability and
> store the virtual addresses as the native unsigned long from mm/. Note
> that this approach is preferred over uintptr_t as Linus explains in [1].
> 
> Opportunistically add a few cosmetic touchups.
> 
> Link: https://lore.kernel.org/all/CAHk-=wj2OHy-5e+srG1fy+ZU00TmZ1NFp6kFLbVLMXHe7A1d-g@mail.gmail.com/ [1]
> Signed-off-by: Carlos Llamas <cmllamas@...gle.com>

With the discussion in [1] and addition of patch 26, I am happy with this.

Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>

[1]: https://lore.kernel.org/all/ZWmEv6-OBEZ08vy5@google.com/