linux-kernel - Re: [PATCH v2 17/28] binder: malloc new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231204115708.40838-1-aliceryhl@google.com>
Date:   Mon,  4 Dec 2023 11:57:08 +0000
From:   Alice Ryhl <aliceryhl@...gle.com>
To:     cmllamas@...gle.com
Cc:     arve@...roid.com, brauner@...nel.org, gregkh@...uxfoundation.org,
        joel@...lfernandes.org, kernel-team@...roid.com,
        linux-kernel@...r.kernel.org, maco@...roid.com, surenb@...gle.com,
        tkjos@...roid.com, Alice Ryhl <aliceryhl@...gle.com>
Subject: Re: [PATCH v2 17/28] binder: malloc new_buffer outside of locks

> Preallocate new_buffer before acquiring the alloc->mutex and hand it
> down to binder_alloc_new_buf_locked(). The new buffer will be used in
> the vast majority of requests (measured at 98.2% in field data). The
> buffer is discarded otherwise. This change is required in preparation
> for transitioning alloc->mutex into a spinlock in subsequent commits.
> 
> Signed-off-by: Carlos Llamas <cmllamas@...gle.com>

Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>