linux-kernel - Re: [PATCH v2 21/28] binder: make oversized buffer code more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231204115719.41739-1-aliceryhl@google.com>
Date:   Mon,  4 Dec 2023 11:57:19 +0000
From:   Alice Ryhl <aliceryhl@...gle.com>
To:     cmllamas@...gle.com
Cc:     arve@...roid.com, brauner@...nel.org, gregkh@...uxfoundation.org,
        joel@...lfernandes.org, kernel-team@...roid.com,
        linux-kernel@...r.kernel.org, maco@...roid.com, surenb@...gle.com,
        tkjos@...roid.com, Alice Ryhl <aliceryhl@...gle.com>
Subject: Re: [PATCH v2 21/28] binder: make oversized buffer code more readable

> The sections in binder_alloc_new_buf_locked() dealing with oversized
> buffers are scattered which makes them difficult to read. Instead,
> consolidate this code into a single block to improve readability.
> 
> No functional change here.
> 
> Signed-off-by: Carlos Llamas <cmllamas@...gle.com>

Tricky, but looks ok.

Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>