linux-kernel - Re: [PATCH 1/2] ASoC: ops: add correct range check for limiting volume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZW3ZY_2_G64dNAeS@hovoldconsulting.com>
Date:   Mon, 4 Dec 2023 14:51:31 +0100
From:   Johan Hovold <johan@...nel.org>
To:     srinivas.kandagatla@...aro.org
Cc:     broonie@...nel.org, alsa-devel@...a-project.org, perex@...ex.cz,
        tiwai@...e.com, linux-sound@...r.kernel.org,
        linux-kernel@...r.kernel.org, johan+linaro@...nel.org
Subject: Re: [PATCH 1/2] ASoC: ops: add correct range check for limiting
 volume

On Mon, Dec 04, 2023 at 12:47:35PM +0000, srinivas.kandagatla@...aro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> Volume can have ranges that start with negative values, ex: -84dB to
> +40dB. Apply correct range check in snd_soc_limit_volume before setting
> the platform_max. Without this patch, for example setting a 0dB limit on
> a volume range of -84dB to +40dB would fail.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

Seems to work as intended with the following patch on the X13s:

Tested-by: Johan Hovold <johan+linaro@...nel.org>
Reviewed-by: Johan Hovold <johan+linaro@...nel.org>

Should you add a Fixes and CC-stable tag so we can get this backported
(at least to 6.5 for the X13s)?

Johan