linux-kernel - Re: [PATCH v2 11/36] media: ti: davinci: Remove useless setting of min_buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e063f152-1b64-4307-b76b-482e905b6bbd@xs4all.nl>
Date:   Mon, 4 Dec 2023 15:30:08 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Benjamin Gaignard <benjamin.gaignard@...labora.com>,
        mchehab@...nel.org, tfiga@...omium.org, m.szyprowski@...sung.com,
        matt.ranostay@...sulko.com
Cc:     linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        linux-staging@...ts.linux.dev, kernel@...labora.com,
        "Lad, Prabhakar" <prabhakar.csengg@...il.com>
Subject: Re: [PATCH v2 11/36] media: ti: davinci: Remove useless setting of
 min_buffers_needed

On 04/12/2023 14:22, Benjamin Gaignard wrote:
> This driver uses min_buffers_needed which vb2 uses to ensure
> start_streaming is called when at least 'min_buffers_needed'
> buffers are queued. However, this driver doesn't need this,
> it can stream fine without any buffers queued.
> Just drop this unnecessary restriction.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...labora.com>
> CC: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
> ---
>  drivers/media/platform/ti/davinci/vpif_capture.c | 1 -
>  drivers/media/platform/ti/davinci/vpif_display.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/media/platform/ti/davinci/vpif_capture.c b/drivers/media/platform/ti/davinci/vpif_capture.c
> index fc42b4bc37e6..300c3cb5cbed 100644
> --- a/drivers/media/platform/ti/davinci/vpif_capture.c
> +++ b/drivers/media/platform/ti/davinci/vpif_capture.c
> @@ -1429,7 +1429,6 @@ static int vpif_probe_complete(void)
>  		q->mem_ops = &vb2_dma_contig_memops;
>  		q->buf_struct_size = sizeof(struct vpif_cap_buffer);
>  		q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
> -		q->min_buffers_needed = 1;
>  		q->lock = &common->lock;
>  		q->dev = vpif_dev;
>  
> diff --git a/drivers/media/platform/ti/davinci/vpif_display.c b/drivers/media/platform/ti/davinci/vpif_display.c
> index 9dbab1003c1d..d45391a4d8f2 100644
> --- a/drivers/media/platform/ti/davinci/vpif_display.c
> +++ b/drivers/media/platform/ti/davinci/vpif_display.c
> @@ -1169,7 +1169,6 @@ static int vpif_probe_complete(void)
>  		q->mem_ops = &vb2_dma_contig_memops;
>  		q->buf_struct_size = sizeof(struct vpif_disp_buffer);
>  		q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
> -		q->min_buffers_needed = 1;
>  		q->lock = &common->lock;
>  		q->dev = vpif_dev;
>  		err = vb2_queue_init(q);

Drop this patch, this is really needed.

Regards,

	Hans