[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <45420f0c-57c8-4ec9-add6-943de53c1604@xs4all.nl>
Date: Mon, 4 Dec 2023 15:32:28 +0100
From: Hans Verkuil <hverkuil@...all.nl>
To: Benjamin Gaignard <benjamin.gaignard@...labora.com>,
mchehab@...nel.org, tfiga@...omium.org, m.szyprowski@...sung.com,
matt.ranostay@...sulko.com
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
linux-staging@...ts.linux.dev, kernel@...labora.com
Subject: Re: [PATCH v2 14/36] media: ti: omap: Remove useless setting of
min_buffers_needed
On 04/12/2023 14:23, Benjamin Gaignard wrote:
> This driver uses min_buffers_needed which vb2 uses to ensure
> start_streaming is called when at least 'min_buffers_needed'
> buffers are queued. However, this driver doesn't need this,
> it can stream fine without any buffers queued.
> Just drop this unnecessary restriction.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...labora.com>
> ---
> drivers/media/platform/ti/omap/omap_vout.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/ti/omap/omap_vout.c b/drivers/media/platform/ti/omap/omap_vout.c
> index 72ce903717d3..f67a45f1441b 100644
> --- a/drivers/media/platform/ti/omap/omap_vout.c
> +++ b/drivers/media/platform/ti/omap/omap_vout.c
> @@ -1404,7 +1404,6 @@ static int __init omap_vout_setup_video_data(struct omap_vout_device *vout)
> vq->ops = &omap_vout_vb2_ops;
> vq->mem_ops = &vb2_dma_contig_memops;
> vq->lock = &vout->lock;
> - vq->min_buffers_needed = 1;
> vfd->queue = vq;
>
> ret = vb2_queue_init(vq);
Drop this patch, this is needed.
Regards,
Hans
Powered by blists - more mailing lists