linux-kernel - Re: [PATCH v2 3/4] mm: Change ghes code to allow poison of non-struct pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231204143650.GB1493156@nvidia.com>
Date:   Mon, 4 Dec 2023 10:36:50 -0400
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     ankita@...dia.com, alex.williamson@...hat.com,
        naoya.horiguchi@....com, akpm@...ux-foundation.org,
        tony.luck@...el.com, linmiaohe@...wei.com, rafael@...nel.org,
        lenb@...nel.org, james.morse@....com, shiju.jose@...wei.com,
        bhelgaas@...gle.com, pabeni@...hat.com, yishaih@...dia.com,
        shameerali.kolothum.thodi@...wei.com, kevin.tian@...el.com,
        aniketa@...dia.com, cjia@...dia.com, kwankhede@...dia.com,
        targupta@...dia.com, vsethi@...dia.com, acurrid@...dia.com,
        apopple@...dia.com, anuaggarwal@...dia.com, jhubbard@...dia.com,
        danw@...dia.com, mochs@...dia.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mm@...ck.org, linux-edac@...r.kernel.org,
        linux-acpi@...r.kernel.org
Subject: Re: [PATCH v2 3/4] mm: Change ghes code to allow poison of
 non-struct pfn

On Sun, Dec 03, 2023 at 12:23:19AM +0100, Borislav Petkov wrote:
> On Thu, Nov 23, 2023 at 06:05:11AM +0530, ankita@...dia.com wrote:
> > -	pfn = PHYS_PFN(physical_addr);
> > -	if (!pfn_valid(pfn) && !arch_is_platform_page(physical_addr)) {
> > -		pr_warn_ratelimited(FW_WARN GHES_PFX
> > -		"Invalid address in generic error data: %#llx\n",
> > -		physical_addr);
> > -		return false;
> > -	}
> 
> You don't just remove a pfn valid test just because your weird device
> can't stomach it - you extend it, like

It wasn't removed. patch 1 moved it to memory_failure() where it makes
a lot more sense.

Jason