linux-kernel - Re: [PATCH 2/2] pinctrl: amd: Mask non-wake source pins with interrupt enabled at suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Dec 2023 15:46:59 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Basavaraj Natikar <Basavaraj.Natikar@....com>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        Marcus Aram <marcus+oss@...r.nl>,
        Mark Herbert <mark.herbert42@...il.com>
Subject: Re: [PATCH 2/2] pinctrl: amd: Mask non-wake source pins with
 interrupt enabled at suspend

On Sun, Dec 3, 2023 at 4:25 AM Mario Limonciello
<mario.limonciello@....com> wrote:

> If a pin isn't marked as a wake source processing any interrupts is
> just going to destroy battery life.  The APU may wake up from a hardware
> sleep state to process the interrupt but not return control to the OS.
>
> Mask interrupt for all non-wake source pins at suspend. They'll be
> re-enabled at resume.
>
> Reported-and-tested-by: Marcus Aram <marcus+oss@...r.nl>
> Reported-and-tested-by: Mark Herbert <mark.herbert42@...il.com>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2812
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

I applied this patch (2/2) to the pin control tree for fixes.

Yours,
Linus Walleij