linux-kernel - Re: [DO NOT MERGE v5 22/37] dt-bindings: display: smi,sm501: SMI SM501 binding json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2a5ce0d0-ad0a-49d7-84a6-055c4b729eec@app.fastmail.com>
Date:   Tue, 05 Dec 2023 14:36:53 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Yoshinori Sato" <ysato@...rs.sourceforge.jp>,
        linux-sh@...r.kernel.org
Cc:     "Damien Le Moal" <dlemoal@...nel.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        "Conor Dooley" <conor+dt@...nel.org>,
        "Geert Uytterhoeven" <geert+renesas@...der.be>,
        "Michael Turquette" <mturquette@...libre.com>,
        "Stephen Boyd" <sboyd@...nel.org>,
        "Dave Airlie" <airlied@...il.com>,
        "Daniel Vetter" <daniel@...ll.ch>,
        "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
        "Maxime Ripard" <mripard@...nel.org>,
        "Thomas Zimmermann" <tzimmermann@...e.de>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Lorenzo Pieralisi" <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        "Bjorn Helgaas" <bhelgaas@...gle.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Jiri Slaby" <jirislaby@...nel.org>,
        "Magnus Damm" <magnus.damm@...il.com>,
        "Daniel Lezcano" <daniel.lezcano@...aro.org>,
        "Rich Felker" <dalias@...c.org>,
        "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>,
        "Lee Jones" <lee@...nel.org>, "Helge Deller" <deller@....de>,
        Heiko Stübner <heiko@...ech.de>,
        "Jernej Skrabec" <jernej.skrabec@...il.com>,
        "Chris Morgan" <macromorgan@...mail.com>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "Randy Dunlap" <rdunlap@...radead.org>,
        "Hyeonggon Yoo" <42.hyeyoo@...il.com>,
        "David Rientjes" <rientjes@...gle.com>,
        "Vlastimil Babka" <vbabka@...e.cz>, "Baoquan He" <bhe@...hat.com>,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        "Guenter Roeck" <linux@...ck-us.net>,
        "Stephen Rothwell" <sfr@...b.auug.org.au>,
        guoren <guoren@...nel.org>,
        "Javier Martinez Canillas" <javierm@...hat.com>,
        "Azeem Shaikh" <azeemshaikh38@...il.com>,
        "Palmer Dabbelt" <palmer@...osinc.com>,
        "Bin Meng" <bmeng@...ylab.org>,
        "Max Filippov" <jcmvbkbc@...il.com>, "Tom Rix" <trix@...hat.com>,
        "Herve Codina" <herve.codina@...tlin.com>,
        "Jacky Huang" <ychuang3@...oton.com>,
        "Lukas Bulwahn" <lukas.bulwahn@...il.com>,
        "Jonathan Corbet" <corbet@....net>,
        "Biju Das" <biju.das.jz@...renesas.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        "Sam Ravnborg" <sam@...nborg.org>,
        "Michael Karcher" <kernel@...rcher.dialup.fu-berlin.de>,
        "Sergey Shtylyov" <s.shtylyov@....ru>,
        "Laurent Pinchart" <laurent.pinchart+renesas@...asonboard.com>,
        linux-ide@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        linux-clk@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-pci@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-fbdev@...r.kernel.org
Subject: Re: [DO NOT MERGE v5 22/37] dt-bindings: display: smi,sm501: SMI SM501 binding
 json-schema

On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote:
> Define SM501 functions and modes.
>
> Signed-off-by: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> ---
>  .../bindings/display/smi,sm501.yaml           | 134 ++++++++++++++++++
>  include/dt-bindings/display/sm501.h           |  25 ++++

It looks like we already have a binding at
Documentation/devicetree/bindings/display/sm501fb.txt

> +  little-endian:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: available on big endian systems, to set different 
> foreign endian.
> +  big-endian:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: available on little endian systems, to set different 
> foreign endian.
> +
> +  swap-fb-endian:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: swap framebuffer byteorder.

Why do you need both the "swap" and the specific little/big
properties?

> +  crt:
> +    description: CRT output control
> +
> +  panel:
> +    description: Panel output control

What type are these?

> +  smi,misc-timing:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Miscellaneous Timing reg value.
> +
> +  smi,misc-control:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Miscellaneous Control reg value.
> +
> +  smi,gpio-low:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: GPIO0 to 31 Control reg value.
> +
> +  smi,gpio-high:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: GPIO32 to 63 Control reg value.

Register values should generally not go into DT


> +
> +  smi,gpio-i2c:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    minItems: 5
> +    description: |
> +      GPIO I2C bus number
> +      1st field - I2C bus number
> +      2nd Field - GPIO SDA
> +      3rd Field - GPIO SCL
> +      4th Field - Timeout
> +      5th Field - udelay

Instead of a bus number and other fields, I think
this should reference an i2c device.

      Arnd