linux-kernel - Re: [PATCHSET 0/2] Get rid of import_single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8562f120-13f2-473c-9024-a4c5996fd5e3@kernel.dk>
Date:   Tue, 5 Dec 2023 06:46:58 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Christian Brauner <brauner@...nel.org>
Cc:     linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk
Subject: Re: [PATCHSET 0/2] Get rid of import_single_range()

On 12/5/23 3:57 AM, Christian Brauner wrote:
> On Mon, Dec 04, 2023 at 10:47:48AM -0700, Jens Axboe wrote:
>> Hi,
>>
>> While looking at this today, I noticed that the 'iov' argument to this
>> function is totally dead code. Patch 1 gets rid of it, and with this
>> function and import_ubuf() now being identical, converts the callers
>> to just use import_ubuf().
>>
>> No functional changes here, just a cleanup removing some dead code.
> 
> Looks good. I've picked this up into vfs.iov_iter but let me know if
> you're already carrying this.

That's fine thanks, I don't have them stashed anywhere.

-- 
Jens Axboe