[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <6BC60156-89E2-4734-BD00-B49A9A6C1D7A@goldelico.com>
Date: Tue, 5 Dec 2023 14:50:08 +0100
From: "H. Nikolaus Schaller" <hns@...delico.com>
To: Maxime Ripard <mripard@...nel.org>
Cc: Andrew Davis <afd@...com>, Frank Binns <frank.binns@...tec.com>,
Donald Robson <donald.robson@...tec.com>,
Matt Coster <matt.coster@...tec.com>,
Adam Ford <aford173@...il.com>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Thomas Zimmermann <tzimmermann@...e.de>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
BenoƮt Cousson <bcousson@...libre.com>,
Tony Lindgren <tony@...mide.com>, Nishanth Menon <nm@...com>,
Vignesh Raghavendra <vigneshr@...com>,
Tero Kristo <kristo@...nel.org>,
Paul Cercueil <paul@...pouillou.net>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, linux-omap@...r.kernel.org,
linux-mips@...r.kernel.org
Subject: Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs
Hi,
> Am 05.12.2023 um 14:29 schrieb Maxime Ripard <mripard@...nel.org>:
>
> Hi,
>
> On Tue, Dec 05, 2023 at 09:18:58AM +0100, H. Nikolaus Schaller wrote:
>>> Am 05.12.2023 um 07:57 schrieb Maxime Ripard <mripard@...nel.org>:
>>>
>>> On Mon, Dec 04, 2023 at 12:22:36PM -0600, Andrew Davis wrote:
>>>> The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from
>>>> multiple vendors. Describe how the SGX GPU is integrated in these SoC,
>>>> including register space and interrupts. Clocks, reset, and power domain
>>>> information is SoC specific.
>>>>
>>>> Signed-off-by: Andrew Davis <afd@...com>
>>>> ---
>>>> .../devicetree/bindings/gpu/img,powervr.yaml | 69 +++++++++++++++++--
>>>> 1 file changed, 63 insertions(+), 6 deletions(-)
>>>
>>> I think it would be best to have a separate file for this, img,sgx.yaml
>>> maybe?
>>
>> Why?
>
> Because it's more convenient?
Is it?
>> The whole family of IMG GPUs is PowerVR and SGX and Rogue are generations 5 and 6++:
>>
>> https://en.wikipedia.org/wiki/PowerVR
>
> That's not really relevant as far as bindings go.
But maybe for choosing binding file names. Well they are machine readable
but sometimes humans work with them.
> We have multiple
> binding files for devices of the same generation, or single bindings
> covering multiple generations.
>
> The important part is that every compatible is documented. It doesn't
> really matter how or where.
Yes, and that is why I would find it more convenient to have a single
"img,powervr.yaml" for all variations unless it becomes filled with
unrelated stuff (which isn't as far as I see).
BR, Nikolaus
Powered by blists - more mailing lists