[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e72085fd-3203-4166-afab-73707d27d174@gmail.com>
Date: Tue, 5 Dec 2023 18:12:18 +0200
From: Ceclan Dumitru <mitrutzceclan@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: linus.walleij@...aro.org, brgl@...ev.pl, andy@...nel.org,
linux-gpio@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
Jonathan Cameron <jic23@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Michael Walle <michael@...le.cc>,
Arnd Bergmann <arnd@...db.de>,
ChiaEn Wu <chiaen_wu@...htek.com>,
Niklas Schnelle <schnelle@...ux.ibm.com>,
Leonard Göhrs <l.goehrs@...gutronix.de>,
Mike Looijmans <mike.looijmans@...ic.nl>,
Haibo Chen <haibo.chen@....com>,
Hugo Villeneuve <hvilleneuve@...onoff.com>,
Ceclan Dumitru <dumitru.ceclan@...log.com>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 2/2] iio: adc: ad7173: add AD7173 driver
On 12/5/23 17:28, Andy Shevchenko wrote:
>> + ref_label = ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_INT_REF];
>> +
>> + fwnode_property_read_string(child, "adi,reference-select",
>> + &ref_label);
>> + ref_sel = match_string(ad7173_ref_sel_str,
>> + ARRAY_SIZE(ad7173_ref_sel_str), ref_label);
>> + if (ref_sel < 0) {
> Can we use fwnode_property_match_property_string()?
fwnode_property_match_string() searches a given string in a device-tree
string array and returns the index. I do not think that this function
fits here as the DT attribute is a single string.
Powered by blists - more mailing lists