linux-kernel - Re: [PATCH] cpu/hotplug: Remove the obsolete CPU hotplug states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbb8ce86-5de8-23e0-b97e-9a25e5e9242e@huawei.com>
Date:   Wed, 6 Dec 2023 00:26:22 +0800
From:   Zenghui Yu <yuzenghui@...wei.com>
To:     <linux-kernel@...r.kernel.org>
CC:     <tglx@...utronix.de>, <peterz@...radead.org>,
        <wanghaibin.wang@...wei.com>, <andriy.shevchenko@...ux.intel.com>,
        <osalvador@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <fw@...len.de>, <apatel@...tanamicro.com>,
        <vikas.shivappa@...ux.intel.com>, <viresh.kumar@...aro.org>,
        Arnd Bergmann <arnd@...db.de>, <tom.zanussi@...ux.intel.com>
Subject: Re: [PATCH] cpu/hotplug: Remove the obsolete CPU hotplug states

+Cc more folks (authors of those "removal" commits) to get review
comments.

On 2023/11/24 20:16, Zenghui Yu wrote:
> There is a bunch of obsolete constants in the cpuhp_state enum that are no
> longer used anywhere in the kernel. The oldest one has been unused for over
> six years.
> 
> Drop all of them to reduce the size of the cpuhp_hp_states array.
> 
>   obsolete hotpulg states		introduced in	unused since
>   ===================================	=============	============
>   CPUHP_X86_APB_DEAD			148b9e2abea6	1b79fc4f2bfd
>   CPUHP_MM_DEMOTION_DEAD		a6a0251c6fce	734c15700cdf
>   CPUHP_LUSTRE_CFS_DEAD			7b737965b331	be65f9ed267f
>   CPUHP_NET_FLOW_PREPARE		a4fc1bfc4206	09c7570480f7
>   CPUHP_AP_IRQ_RISCV_STARTING		6b7ce8927b5a	832f15f42646
>   CPUHP_AP_MICROCODE_LOADER		78f4e932f776	5af05b8d51a8
>   CPUHP_AP_PERF_X86_CQM_STARTING	f07048270423	c39a0e2c8850
>   CPUHP_AP_MIPS_OP_LOONGSON3_STARTING	65264e3bc3d4	e258958945c6
>   CPUHP_AP_MARCO_TIMER_STARTING		eb0a9d8c672d	446262b27285
>   CPUHP_AP_PERF_X86_CQM_ONLINE		f07048270423	c39a0e2c8850
>   CPUHP_AP_PERF_X86_IDXD_ONLINE		81dd4d4d6178	never used
>   CPUHP_AP_MM_DEMOTION_ONLINE		a6a0251c6fce	734c15700cdf
> 
> Signed-off-by: Zenghui Yu <yuzenghui@...wei.com>
> ---
>  include/linux/cpuhotplug.h | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
> index efc0c0b07efb..af6c21aab985 100644
> --- a/include/linux/cpuhotplug.h
> +++ b/include/linux/cpuhotplug.h
> @@ -66,15 +66,12 @@ enum cpuhp_state {
>  	CPUHP_PERF_POWER,
>  	CPUHP_PERF_SUPERH,
>  	CPUHP_X86_HPET_DEAD,
> -	CPUHP_X86_APB_DEAD,
>  	CPUHP_X86_MCE_DEAD,
>  	CPUHP_VIRT_NET_DEAD,
>  	CPUHP_IBMVNIC_DEAD,
>  	CPUHP_SLUB_DEAD,
>  	CPUHP_DEBUG_OBJ_DEAD,
>  	CPUHP_MM_WRITEBACK_DEAD,
> -	/* Must be after CPUHP_MM_VMSTAT_DEAD */
> -	CPUHP_MM_DEMOTION_DEAD,
>  	CPUHP_MM_VMSTAT_DEAD,
>  	CPUHP_SOFTIRQ_DEAD,
>  	CPUHP_NET_MVNETA_DEAD,
> @@ -96,7 +93,6 @@ enum cpuhp_state {
>  	CPUHP_NET_DEV_DEAD,
>  	CPUHP_PCI_XGENE_DEAD,
>  	CPUHP_IOMMU_IOVA_DEAD,
> -	CPUHP_LUSTRE_CFS_DEAD,
>  	CPUHP_AP_ARM_CACHE_B15_RAC_DEAD,
>  	CPUHP_PADATA_DEAD,
>  	CPUHP_AP_DTPM_CPU_DEAD,
> @@ -118,7 +114,6 @@ enum cpuhp_state {
>  	CPUHP_XEN_EVTCHN_PREPARE,
>  	CPUHP_ARM_SHMOBILE_SCU_PREPARE,
>  	CPUHP_SH_SH3X_PREPARE,
> -	CPUHP_NET_FLOW_PREPARE,
>  	CPUHP_TOPOLOGY_PREPARE,
>  	CPUHP_NET_IUCV_PREPARE,
>  	CPUHP_ARM_BL_PREPARE,
> @@ -151,18 +146,14 @@ enum cpuhp_state {
>  	CPUHP_AP_IRQ_ARMADA_XP_STARTING,
>  	CPUHP_AP_IRQ_BCM2836_STARTING,
>  	CPUHP_AP_IRQ_MIPS_GIC_STARTING,
> -	CPUHP_AP_IRQ_RISCV_STARTING,
>  	CPUHP_AP_IRQ_LOONGARCH_STARTING,
>  	CPUHP_AP_IRQ_SIFIVE_PLIC_STARTING,
>  	CPUHP_AP_ARM_MVEBU_COHERENCY,
> -	CPUHP_AP_MICROCODE_LOADER,
>  	CPUHP_AP_PERF_X86_AMD_UNCORE_STARTING,
>  	CPUHP_AP_PERF_X86_STARTING,
>  	CPUHP_AP_PERF_X86_AMD_IBS_STARTING,
> -	CPUHP_AP_PERF_X86_CQM_STARTING,
>  	CPUHP_AP_PERF_X86_CSTATE_STARTING,
>  	CPUHP_AP_PERF_XTENSA_STARTING,
> -	CPUHP_AP_MIPS_OP_LOONGSON3_STARTING,
>  	CPUHP_AP_ARM_VFP_STARTING,
>  	CPUHP_AP_ARM64_DEBUG_MONITORS_STARTING,
>  	CPUHP_AP_PERF_ARM_HW_BREAKPOINT_STARTING,
> @@ -179,7 +170,6 @@ enum cpuhp_state {
>  	CPUHP_AP_QCOM_TIMER_STARTING,
>  	CPUHP_AP_TEGRA_TIMER_STARTING,
>  	CPUHP_AP_ARMADA_TIMER_STARTING,
> -	CPUHP_AP_MARCO_TIMER_STARTING,
>  	CPUHP_AP_MIPS_GIC_TIMER_STARTING,
>  	CPUHP_AP_ARC_TIMER_STARTING,
>  	CPUHP_AP_RISCV_TIMER_STARTING,
> @@ -217,9 +207,7 @@ enum cpuhp_state {
>  	CPUHP_AP_PERF_X86_AMD_UNCORE_ONLINE,
>  	CPUHP_AP_PERF_X86_AMD_POWER_ONLINE,
>  	CPUHP_AP_PERF_X86_RAPL_ONLINE,
> -	CPUHP_AP_PERF_X86_CQM_ONLINE,
>  	CPUHP_AP_PERF_X86_CSTATE_ONLINE,
> -	CPUHP_AP_PERF_X86_IDXD_ONLINE,
>  	CPUHP_AP_PERF_S390_CF_ONLINE,
>  	CPUHP_AP_PERF_S390_SF_ONLINE,
>  	CPUHP_AP_PERF_ARM_CCI_ONLINE,
> @@ -252,8 +240,6 @@ enum cpuhp_state {
>  	CPUHP_AP_BASE_CACHEINFO_ONLINE,
>  	CPUHP_AP_ONLINE_DYN,
>  	CPUHP_AP_ONLINE_DYN_END		= CPUHP_AP_ONLINE_DYN + 30,
> -	/* Must be after CPUHP_AP_ONLINE_DYN for node_states[N_CPU] update */
> -	CPUHP_AP_MM_DEMOTION_ONLINE,
>  	CPUHP_AP_X86_HPET_ONLINE,
>  	CPUHP_AP_X86_KVM_CLK_ONLINE,
>  	CPUHP_AP_ACTIVE,
>