[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231205-agency-paralyses-2a7b6df25c66@spud>
Date: Tue, 5 Dec 2023 16:55:42 +0000
From: Conor Dooley <conor@...nel.org>
To: Johan Jonker <jbx6244@...il.com>
Cc: Alex Bee <knaerzche@...il.com>, heiko@...ech.de,
hjc@...k-chips.com, maarten.lankhorst@...ux.intel.com,
mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com,
daniel@...ll.ch, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: drm: rockchip: convert
inno_hdmi-rockchip.txt to yaml
On Mon, Dec 04, 2023 at 09:47:15PM +0100, Johan Jonker wrote:
> On 12/4/23 19:56, Alex Bee wrote:
> > Am 04.12.23 um 18:39 schrieb Johan Jonker:
> >> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,inno-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,inno-hdmi.yaml
> >> new file mode 100644
> >> index 000000000000..96889c86849a
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,inno-hdmi.yaml
> >> @@ -0,0 +1,103 @@
> >> +# SPDX-License-Identifier: GPL-2.0
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/display/rockchip/rockchip,inno-hdmi.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Rockchip Innosilicon HDMI controller
> >> +
> >> +maintainers:
> >> + - Sandy Huang <hjc@...k-chips.com>
> >> + - Heiko Stuebner <heiko@...ech.de>
> >> +
> >> +properties:
> >> + compatible:
> >> + enum:
> >> + - rockchip,rk3036-inno-hdmi
> >> +
> >> + reg:
> >> + maxItems: 1
> >> +
> >> + interrupts:
> >> + maxItems: 1
> >> +
> >> + clocks:
> >> + maxItems: 1
>
> > The interrupts/clock description exists already in the txt-bindings - so how about:
> >
> > + items:
> > + - descrition: ....
> >> +
>
> It's not common to do so when there's only one clock and nothing special to mention.
> Used this style for most of my conversions.
> Further rational might be given by Krzysztof and co.
Ye, when there is no ambiguity, having the description is not
required.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists