lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAM9d7ciOp_O5N1TDX0HyKavykirByAYrqzcmM-_6ZWjMv-47WQ@mail.gmail.com> Date: Tue, 5 Dec 2023 09:24:42 -0800 From: Namhyung Kim <namhyung@...nel.org> To: Arnaldo Carvalho de Melo <acme@...nel.org> Cc: Ilkka Koskinen <ilkka@...amperecomputing.com>, Ian Rogers <irogers@...gle.com>, John Garry <john.g.garry@...cle.com>, Will Deacon <will@...nel.org>, James Clark <james.clark@....com>, Mike Leach <mike.leach@...aro.org>, Leo Yan <leo.yan@...aro.org>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>, Kajol Jain <kjain@...ux.ibm.com>, linux-arm-kernel@...ts.infradead.org, linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v1 1/2] perf metrics: Avoid segv if default metricgroup isn't set Hi Arnaldo, On Tue, Dec 5, 2023 at 7:51 AM Arnaldo Carvalho de Melo <acme@...nel.org> wrote: > > Em Mon, Dec 04, 2023 at 07:33:18PM -0800, Namhyung Kim escreveu: > > On Mon, Dec 4, 2023 at 2:45 PM Ilkka Koskinen <ilkka@...amperecomputing.com> wrote: > > > On Mon, 4 Dec 2023, Ian Rogers wrote: > > > > A metric is default by having "Default" within its groups. The default > > > > metricgroup name needn't be set and this can result in segv in > > > > default_metricgroup_cmp and perf_stat__print_shadow_stats_metricgroup > > > > that assume it has a value when there is a Default metric group. To > > > > avoid the segv initialize the value to "". > > > > > Fixes: 1c0e47956a8e ("perf metrics: Sort the Default metricgroup") > > > > Signed-off-by: Ian Rogers <irogers@...gle.com> > > > > Thanks! I was going to look for the bug but got pulled to other > > > tasks. The patch looks good to me and I tested it successfully on > > > AmpereOne. > > > > Reviewed-and-tested-by: Ilkka Koskinen <ilkka@...amperecomputing.com> > > > Looks like it needs to go through perf-tools for v6.7. > > Ian, do you think this one is enough? > > So I had this on my local perf-tools-next, removed now, I also have some > other fixes by Ian on the tmp.perf-tools-next, please let me know what > you guys decide to have in perf-tools for v6.7 so that I can remove it > from there. I think we need this one and the Ampere default-metric-group fix. https://lore.kernel.org/r/20231201021550.1109196-2-ilkka@os.amperecomputing.com/ Also perf list JSON fix can go to v6.7. https://lore.kernel.org/r/20231129213428.2227448-2-irogers@google.com/ Thanks, Namhyung
Powered by blists - more mailing lists