linux-kernel - Re: [PATCH 36/48] perf annotate-data: Introduce struct data_loc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <4A9408B2-46A8-45B2-BC0E-A4187F7AD462@linux.vnet.ibm.com>
Date:   Tue, 5 Dec 2023 12:47:29 +0530
From:   Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ian Rogers <irogers@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-perf-users <linux-perf-users@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Stephane Eranian <eranian@...gle.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-toolchains@...r.kernel.org, linux-trace-devel@...r.kernel.org
Subject: Re: [PATCH 36/48] perf annotate-data: Introduce struct data_loc_info



> On 05-Dec-2023, at 5:40 AM, Namhyung Kim <namhyung@...nel.org> wrote:
> 
> Hello,
> 
> On Sun, Dec 3, 2023 at 8:22 AM Athira Rajeev
> <atrajeev@...ux.vnet.ibm.com> wrote:
>> Hi Namhyung,
>> 
>> I have a thought there. For the type and typeoff sort keys to work, we depend on Dwarf support in perf, right ?
>> If the perf is built without dwarf support ( either due to older elfutils or missing libdw.h ) , find_data_type will return NULL and we will get “unknown” for Data Type and Data Type Offset in the result.
> 
> Yes, right.
> 
>> 
>> Can we add a pr_debug line in find_data_type (which is in else part for HAVE_DWARF_SUPPORT) so that user can understand if “unknown” is due to missing devel during the build ? Or may be restrict -s type,typeoff if dwarf support is missing ?
> 
> I think it's better to add a warning if DWARF is not supported.
> Thanks for your review!

Sure, having a warning if DWARF is not supported will help

Thanks
Athira
> 
> Namhyung