linux-kernel - Re: [PATCH v5 9/9] slub: Update frozen slabs documentations in the source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 5 Dec 2023 10:39:01 +0100
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Chengming Zhou <chengming.zhou@...ux.dev>,
        "Christoph Lameter (Ampere)" <cl@...ux.com>
Cc:     penberg@...nel.org, rientjes@...gle.com, iamjoonsoo.kim@....com,
        akpm@...ux-foundation.org, roman.gushchin@...ux.dev,
        42.hyeyoo@...il.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Chengming Zhou <zhouchengming@...edance.com>
Subject: Re: [PATCH v5 9/9] slub: Update frozen slabs documentations in the
 source

On 12/5/23 07:06, Chengming Zhou wrote:
> On 2023/12/5 05:41, Christoph Lameter (Ampere) wrote:
>> On Thu, 2 Nov 2023, chengming.zhou@...ux.dev wrote:
>> 
>>> From: Chengming Zhou <zhouchengming@...edance.com>
>>>
>>> The current updated scheme (which this series implemented) is:
>>> - node partial slabs: PG_Workingset && !frozen
>>> - cpu partial slabs: !PG_Workingset && !frozen
>>> - cpu slabs: !PG_Workingset && frozen
>>> - full slabs: !PG_Workingset && !frozen
>> 
>> The above would be good to include in the comments.
>> 
>> Acked-by: Christoph Lameter (Ampere) <cl@...ux.com>
>> 
> 
> Thanks for your review and suggestion!
> 
> Maybe something like this:

Thanks, added.

> diff --git a/mm/slub.c b/mm/slub.c
> index 623c17a4cdd6..21f88bd9c16b 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -93,6 +93,12 @@
>   *   by clearing the PG_workingset flag when moving out of the node
>   *   partial list. Please see __slab_free() for more details.
>   *
> + *   To sum up, the current scheme is:
> + *   - node partial slab: PG_Workingset && !frozen
> + *   - cpu partial slab: !PG_Workingset && !frozen
> + *   - cpu slab: !PG_Workingset && frozen
> + *   - full slab: !PG_Workingset && !frozen
> + *
>   *   list_lock
>   *
>   *   The list_lock protects the partial and full list on each node and