| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <b6cb832f-4e20-4737-a129-493f487a537a@kontron.de>
Date: Wed, 6 Dec 2023 15:48:39 +0100
From: Frieder Schrempf <frieder.schrempf@...tron.de>
To: Shawn Guo <shawnguo@...nel.org>, Frieder Schrempf <frieder@...s.de>
Cc: Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Rob Herring <robh+dt@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Alexander Stein <alexander.stein@...tq-group.com>,
Fabio Estevam <festevam@...il.com>,
Gregor Herburger <gregor.herburger@...tq-group.com>,
Marcel Ziswiler <marcel.ziswiler@...adex.com>,
Marek Vasut <marex@...x.de>,
NXP Linux Team <linux-imx@....com>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Philippe Schenker <philippe.schenker@...adex.com>,
Tim Harvey <tharvey@...eworks.com>
Subject: Re: [PATCH v2 02/14] arm64: dts: imx8mm-kontron: Add DL
(Display-Line) overlay with LVDS support
On 06.12.23 03:43, Shawn Guo wrote:
> On Thu, Nov 30, 2023 at 05:16:02PM +0100, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@...tron.de>
>>
>> The Kontron Electronics DL i.MX8MM consists of the BL i.MX8MM board
>> and a 7" LVDS panel. Provide an overlay that enables the panel.
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>
>> ---
>> Changes for v2:
>> * Rework DSI mux GPIO logic to be compatible with overlay
>> ---
>> arch/arm64/boot/dts/freescale/Makefile | 4 +
>> .../boot/dts/freescale/imx8mm-kontron-dl.dtso | 200 ++++++++++++++++++
>> 2 files changed, 204 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso
>>
>> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
>> index 300049037eb0b..e08024797721a 100644
>> --- a/arch/arm64/boot/dts/freescale/Makefile
>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>> @@ -166,6 +166,10 @@ dtb-$(CONFIG_ARCH_MXC) += imx8ulp-evk.dtb
>> dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb
>> dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla.dtb
>>
>> +imx8mm-kontron-dl-dtbs := imx8mm-kontron-bl.dtb imx8mm-kontron-dl.dtbo
>> +
>> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-dl.dtb
>> +
>> imx8mm-venice-gw72xx-0x-imx219-dtbs := imx8mm-venice-gw72xx-0x.dtb imx8mm-venice-gw72xx-0x-imx219.dtbo
>> imx8mm-venice-gw72xx-0x-rpidsi-dtbs := imx8mm-venice-gw72xx-0x.dtb imx8mm-venice-gw72xx-0x-rpidsi.dtbo
>> imx8mm-venice-gw72xx-0x-rs232-rts-dtbs := imx8mm-venice-gw72xx-0x.dtb imx8mm-venice-gw72xx-0x-rs232-rts.dtbo
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso b/arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso
>> new file mode 100644
>> index 0000000000000..c6369072577e0
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso
>> @@ -0,0 +1,200 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (C) 2023 Kontron Electronics GmbH
>> + */
>> +
>> +/dts-v1/;
>> +/plugin/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include "imx8mm-pinfunc.h"
>> +
>> +&{/} {
>> + compatible = "kontron,imx8mm-bl", "kontron,imx8mm-sl", "fsl,imx8mm";
>> +
>> + backlight: backlight {
>> + compatible = "pwm-backlight";
>> + pwms = <&pwm1 0 50000 0>;
>> + brightness-levels = <0 100>;
>> + num-interpolated-steps = <100>;
>> + default-brightness-level = <100>;
>> + };
>> +
>> + panel {
>> + compatible = "panel-lvds";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_panel>;
>> + backlight = <&backlight>;
>> + data-mapping = "vesa-24";
>> + enable-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
>> + height-mm = <86>;
>> + width-mm = <154>;
>> +
>> + panel-timing {
>> + clock-frequency = <51200000>;
>> + hactive = <1024>;
>> + vactive = <600>;
>> + hsync-len = <1>;
>> + hfront-porch = <160>;
>> + hback-porch = <160>;
>> + vsync-len = <1>;
>> + vfront-porch = <12>;
>> + vback-porch = <23>;
>> + };
>> +
>> + port {
>> + panel_out_bridge: endpoint {
>> + remote-endpoint = <&bridge_out_panel>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&dsi_mux_sel_hdmi {
>> + status = "disabled";
>> +};
>> +
>> +&dsi_mux_sel_lvds {
>> + status = "okay";
>> +};
>> +
>> +&dsi_out_bridge {
>> + remote-endpoint = <&bridge_in_dsi_lvds>;
>> +};
>> +
>> +&gpio3 {
>> + panel_rst {
>> + gpio-hog;
>> + gpios = <20 GPIO_ACTIVE_HIGH>;
>> + output-high;
>> + line-name = "panel-reset";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_panel_rst>;
>> + };
>> +
>> + panel_stby {
>> + gpio-hog;
>> + gpios = <21 GPIO_ACTIVE_HIGH>;
>> + output-high;
>> + line-name = "panel-standby";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_panel_stby>;
>> + };
>> +
>> + panel_hinv {
>> + gpio-hog;
>> + gpios = <24 GPIO_ACTIVE_HIGH>;
>> + output-high;
>> + line-name = "panel-horizontal-invert";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_panel_hinv>;
>> + };
>> +
>> + panel_vinv {
>> + gpio-hog;
>> + gpios = <25 GPIO_ACTIVE_HIGH>;
>> + output-low;
>> + line-name = "panel-vertical-invert";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_panel_vinv>;
>> + };
>> +};
>> +
>> +&hdmi {
>> + status = "disabled";
>> +};
>> +
>> +&i2c2 {
>> + clock-frequency = <400000>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_i2c2>;
>> + status = "okay";
>> +
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + gt911@5d {
>> + compatible = "goodix,gt928";
>> + reg = <0x5d>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_touch>;
>> + interrupt-parent = <&gpio3>;
>> + interrupts = <22 8>;
>> + reset-gpios = <&gpio3 23 0>;
>> + irq-gpios = <&gpio3 22 0>;
>> + };
>> +};
>> +
>> +&lvds {
>> + status = "okay";
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@2 {
>> + reg = <2>;
>
> Have a newline between properties and child node.
Sure, fixed in v3
>
>> + bridge_out_panel: endpoint {
>> + remote-endpoint = <&panel_out_bridge>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&pwm1 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pwm1>;
>> + status = "okay";
>> +};
>> +
>> +&iomuxc {
>> + pinctrl_panel_rst: panelrstgrp {
>> + fsl,pins = <
>> + MX8MM_IOMUXC_SAI5_RXC_GPIO3_IO20 0x19
>> + >;
>> + };
>> +
>> + pinctrl_panel_stby: panelstbygrp {
>> + fsl,pins = <
>> + MX8MM_IOMUXC_SAI5_RXD0_GPIO3_IO21 0x19
>> + >;
>> + };
>> +
>> + pinctrl_panel_hinv: panelhinvgrp {
>> + fsl,pins = <
>> + MX8MM_IOMUXC_SAI5_RXD3_GPIO3_IO24 0x19
>> + >;
>> + };
>> +
>> + pinctrl_panel_vinv: panelvinvgrp {
>> + fsl,pins = <
>> + MX8MM_IOMUXC_SAI5_MCLK_GPIO3_IO25 0x19
>> + >;
>> + };
>> +
>> + pinctrl_i2c2: i2c2grp {
>
> Could you sort the pinctrl nodes alphabetically?
Sure, done in v3
Thanks
Frieder
>> + fsl,pins = <
>> + MX8MM_IOMUXC_I2C2_SCL_I2C2_SCL 0x40000083
>> + MX8MM_IOMUXC_I2C2_SDA_I2C2_SDA 0x40000083
>> + >;
>> + };
>> +
>> + pinctrl_pwm1: pwm1grp {
>> + fsl,pins = <
>> + MX8MM_IOMUXC_SPDIF_EXT_CLK_PWM1_OUT 0x6
>> + >;
>> + };
>> +
>> + pinctrl_panel: panelgrp {
>> + fsl,pins = <
>> + MX8MM_IOMUXC_SAI5_RXFS_GPIO3_IO19 0x19
>> + >;
>> + };
>> +
>> + pinctrl_touch: touchgrp {
>> + fsl,pins = <
>> + MX8MM_IOMUXC_SAI5_RXD1_GPIO3_IO22 0x19
>> + MX8MM_IOMUXC_SAI5_RXD2_GPIO3_IO23 0x19
>> + >;
>> + };
>> +};
>> --
>> 2.43.0
>>
Powered by blists - more mailing lists