linux-kernel - RE: [EXT] Re: [PATCH] wifi: mwifiex: added extra delay for firmware ready.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PA4PR04MB963836544F03B5D5D3514355D184A@PA4PR04MB9638.eurprd04.prod.outlook.com>
Date:   Wed, 6 Dec 2023 01:53:03 +0000
From:   David Lin <yu-hao.lin@....com>
To:     Francesco Dolcini <francesco@...cini.it>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "briannorris@...omium.org" <briannorris@...omium.org>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        Pete Hsieh <tsung-hsien.hsieh@....com>
Subject: RE: [EXT] Re: [PATCH] wifi: mwifiex: added extra delay for firmware
 ready.

> From: Francesco Dolcini <francesco@...cini.it>
> Sent: Wednesday, December 6, 2023 4:01 AM
> To: David Lin <yu-hao.lin@....com>
> Cc: linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org;
> briannorris@...omium.org; kvalo@...nel.org; francesco@...cini.it; Pete
> Hsieh <tsung-hsien.hsieh@....com>
> Subject: [EXT] Re: [PATCH] wifi: mwifiex: added extra delay for firmware ready.
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> Hello David,
> 
> thanks for your patch. Planning to run some test on this over the next days and
> we'll provide some actual feedback if this really solves the issue we are
> affected by.
> 
> Just a couple of nitpicky comments on the actual patch.
> 
> 
> On the commit message you should use imperative mood, e.g.
> 
> `wifi: mwifiex: add extra delay for firmware ready`
> 
> with no period at the end of the line.
> 

Thanks. I will fix it in patch v2.

> On Tue, Nov 28, 2023 at 04:25:44PM +0800, David Lin wrote:
> > For SDIO IW416, in a corner case FW may return ready before complete
> > full initialization.
> > Command timeout may occur at driver load after reboot.
> > Workaround by adding 100ms delay at checking FW status.
> >
> > Signed-off-by: David Lin <yu-hao.lin@....com>
> 
> Add
> 
> Cc: stable@...
> 

Thanks. I will add "cc: stable" in patch v2.

> > ---
> >  drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c
> > b/drivers/net/wireless/marvell/mwifiex/sdio.c
> > index 6462a0ffe698..744e9403430a 100644
> > --- a/drivers/net/wireless/marvell/mwifiex/sdio.c
> > +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
> > @@ -783,6 +783,9 @@ static int mwifiex_check_fw_status(struct
> mwifiex_adapter *adapter,
> >               ret = -1;
> >       }
> >
> > +     if (!ret)
> > +             msleep(100);
> > +
> 
> you could just add the delay after
> 
>   if (firmware_stat == FIRMWARE_READY_SDIO) {
> 
> this would be more read-able to me. Adding also a short comment like
> 
>   /* Firmware might pretend to be ready, when it's not.
>    * Wait a little bit more as a workaround */
> 

O.K.

> 
> Francesco