| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZXCch6o2Wfp3fQQw@makrotopia.org>
Date: Wed, 6 Dec 2023 16:08:39 +0000
From: Daniel Golle <daniel@...rotopia.org>
To: Rob Herring <robh@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Chunfeng Yun <chunfeng.yun@...iatek.com>,
Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Felix Fietkau <nbd@....name>, John Crispin <john@...ozen.org>,
Sean Wang <sean.wang@...iatek.com>,
Mark Lee <Mark-MC.Lee@...iatek.com>,
Lorenzo Bianconi <lorenzo@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
Alexander Couzens <lynxis@...0.eu>,
Qingfang Deng <dqfext@...il.com>,
SkyLake Huang <SkyLake.Huang@...iatek.com>,
Philipp Zabel <p.zabel@...gutronix.de>, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-phy@...ts.infradead.org
Subject: Re: [RFC PATCH v2 7/8] dt-bindings: net: mediatek,net: fix and
complete mt7988-eth binding
On Wed, Dec 06, 2023 at 07:38:16AM -0600, Rob Herring wrote:
> On Wed, Dec 06, 2023 at 01:45:02AM +0000, Daniel Golle wrote:
> > Complete support for MT7988 which comes with 3 MACs, SRAM for DMA
> > descriptors and uses a dedicated PCS for the SerDes units.
> >
> > Fixes: c94a9aabec36 ("dt-bindings: net: mediatek,net: add mt7988-eth binding")
> > Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> > ---
> > .../devicetree/bindings/net/mediatek,net.yaml | 148 +++++++++++++++++-
> > 1 file changed, 146 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> > index 030d106bc7d3f..ca0667c51c1c2 100644
> > --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
> > +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> > @@ -28,7 +28,10 @@ properties:
> > - ralink,rt5350-eth
> >
> > reg:
> > - maxItems: 1
> > + minItems: 1
> > + items:
> > + - description: Base of registers used to program the ethernet controller
> > + - description: SRAM region used for DMA descriptors
>
> Is this a dedicated SRAM for this purpose, or a common one partitioned
> up. mmio-sram and a phandle is how to do the latter.
The SRAM memory sits just next to the Ethernet and dedicated for this
purpose, at least in theory. I'm not aware of the internal details here.
>
> >
> > clocks: true
> > clock-names: true
> > @@ -115,6 +118,9 @@ allOf:
> > - mediatek,mt7623-eth
> > then:
> > properties:
> > + reg:
> > + maxItems: 1
> > +
> > interrupts:
> > maxItems: 3
> >
> > @@ -149,6 +155,9 @@ allOf:
> > - mediatek,mt7621-eth
> > then:
> > properties:
> > + reg:
> > + maxItems: 1
> > +
> > interrupts:
> > maxItems: 1
> >
> > @@ -174,6 +183,9 @@ allOf:
> > const: mediatek,mt7622-eth
> > then:
> > properties:
> > + reg:
> > + maxItems: 1
> > +
> > interrupts:
> > maxItems: 3
> >
> > @@ -215,6 +227,9 @@ allOf:
> > const: mediatek,mt7629-eth
> > then:
> > properties:
> > + reg:
> > + maxItems: 1
> > +
> > interrupts:
> > maxItems: 3
> >
> > @@ -257,6 +272,9 @@ allOf:
> > const: mediatek,mt7981-eth
> > then:
> > properties:
> > + reg:
> > + maxItems: 1
> > +
> > interrupts:
> > minItems: 4
> >
> > @@ -295,6 +313,9 @@ allOf:
> > const: mediatek,mt7986-eth
> > then:
> > properties:
> > + reg:
> > + maxItems: 1
> > +
> > interrupts:
> > minItems: 4
> >
> > @@ -333,8 +354,13 @@ allOf:
> > const: mediatek,mt7988-eth
> > then:
> > properties:
> > + reg:
> > + maxItems: 2
>
> Don't need maxItems here. That's already the max.
Ack.
>
> > + minItems: 2
> > +
> > interrupts:
> > minItems: 4
> > + maxItems: 4
> >
> > clocks:
> > minItems: 24
> > @@ -368,7 +394,7 @@ allOf:
> > - const: top_netsys_warp_sel
> >
> > patternProperties:
> > - "^mac@[0-1]$":
> > + "^mac@[0-2]$":
> > type: object
> > unevaluatedProperties: false
> > allOf:
> > @@ -382,6 +408,9 @@ patternProperties:
> > reg:
> > maxItems: 1
> >
> > + phys:
> > + maxItems: 1
> > +
> > required:
> > - reg
> > - compatible
> > @@ -559,3 +588,118 @@ examples:
> > };
> > };
> > };
> > +
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/clock/mediatek,mt7988-clk.h>
>
>
> Why is fixing the binding needing a new example? Is this example really
> different enough to justify a whole other example?
Starting from MT7988 the PCS needs to be referenced as pcs-handle in the
MAC node, so that is a bit different. If you don't think that justifies
including the additional example I will drop that.
>
> > +
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + ethernet@...00000 {
> > + compatible = "mediatek,mt7988-eth";
> > + reg = <0 0x15100000 0 0x80000>, <0 0x15400000 0 0x380000>;
> > + interrupts = <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 199 IRQ_TYPE_LEVEL_HIGH>;
> > +
> > + clocks = <ðsys CLK_ETHDMA_XGP1_EN>,
> > + <ðsys CLK_ETHDMA_XGP2_EN>,
> > + <ðsys CLK_ETHDMA_XGP3_EN>,
> > + <ðsys CLK_ETHDMA_FE_EN>,
> > + <ðsys CLK_ETHDMA_GP2_EN>,
> > + <ðsys CLK_ETHDMA_GP1_EN>,
> > + <ðsys CLK_ETHDMA_GP3_EN>,
> > + <ðsys CLK_ETHDMA_ESW_EN>,
> > + <ðsys CLK_ETHDMA_CRYPT0_EN>,
> > + <ðwarp CLK_ETHWARP_WOCPU2_EN>,
> > + <ðwarp CLK_ETHWARP_WOCPU1_EN>,
> > + <ðwarp CLK_ETHWARP_WOCPU0_EN>,
> > + <&topckgen CLK_TOP_ETH_GMII_SEL>,
> > + <&topckgen CLK_TOP_ETH_REFCK_50M_SEL>,
> > + <&topckgen CLK_TOP_ETH_SYS_200M_SEL>,
> > + <&topckgen CLK_TOP_ETH_SYS_SEL>,
> > + <&topckgen CLK_TOP_ETH_XGMII_SEL>,
> > + <&topckgen CLK_TOP_ETH_MII_SEL>,
> > + <&topckgen CLK_TOP_NETSYS_SEL>,
> > + <&topckgen CLK_TOP_NETSYS_500M_SEL>,
> > + <&topckgen CLK_TOP_NETSYS_PAO_2X_SEL>,
> > + <&topckgen CLK_TOP_NETSYS_SYNC_250M_SEL>,
> > + <&topckgen CLK_TOP_NETSYS_PPEFB_250M_SEL>,
> > + <&topckgen CLK_TOP_NETSYS_WARP_SEL>;
> > +
> > + clock-names = "xgp1", "xgp2", "xgp3", "fe", "gp2", "gp1",
> > + "gp3", "esw", "crypto",
> > + "ethwarp_wocpu2", "ethwarp_wocpu1",
> > + "ethwarp_wocpu0", "top_eth_gmii_sel",
> > + "top_eth_refck_50m_sel", "top_eth_sys_200m_sel",
> > + "top_eth_sys_sel", "top_eth_xgmii_sel",
> > + "top_eth_mii_sel", "top_netsys_sel",
> > + "top_netsys_500m_sel", "top_netsys_pao_2x_sel",
> > + "top_netsys_sync_250m_sel",
> > + "top_netsys_ppefb_250m_sel",
> > + "top_netsys_warp_sel";
> > + assigned-clocks = <&topckgen CLK_TOP_NETSYS_2X_SEL>,
> > + <&topckgen CLK_TOP_NETSYS_GSW_SEL>,
> > + <&topckgen CLK_TOP_USXGMII_SBUS_0_SEL>,
> > + <&topckgen CLK_TOP_USXGMII_SBUS_1_SEL>,
> > + <&topckgen CLK_TOP_SGM_0_SEL>,
> > + <&topckgen CLK_TOP_SGM_1_SEL>;
> > + assigned-clock-parents = <&apmixedsys CLK_APMIXED_NET2PLL>,
> > + <&topckgen CLK_TOP_NET1PLL_D4>,
> > + <&topckgen CLK_TOP_NET1PLL_D8_D4>,
> > + <&topckgen CLK_TOP_NET1PLL_D8_D4>,
> > + <&apmixedsys CLK_APMIXED_SGMPLL>,
> > + <&apmixedsys CLK_APMIXED_SGMPLL>;
> > + mediatek,ethsys = <ðsys>;
> > + mediatek,infracfg = <&topmisc>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + mac@0 {
> > + compatible = "mediatek,eth-mac";
> > + reg = <0>;
> > + phy-mode = "internal"; /* CPU port of built-in 1GE switch */
> > +
> > + fixed-link {
> > + speed = <10000>;
> > + full-duplex;
> > + pause;
> > + };
> > + };
> > +
> > + mac@1 {
> > + compatible = "mediatek,eth-mac";
> > + reg = <1>;
> > + phy-handle = <&int_2p5g_phy>;
> > + };
> > +
> > + mac@2 {
> > + compatible = "mediatek,eth-mac";
> > + reg = <2>;
> > + pcs-handle = <&usxgmiisys0>;
> > + phy-handle = <&phy0>;
> > + };
> > +
> > + mdio_bus: mdio-bus {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + /* external PHY */
> > + phy0: ethernet-phy@0 {
> > + reg = <0>;
> > + compatible = "ethernet-phy-ieee802.3-c45";
> > + };
> > +
> > + /* internal 2.5G PHY */
> > + int_2p5g_phy: ethernet-phy@15 {
> > + reg = <15>;
> > + compatible = "ethernet-phy-ieee802.3-c45";
> > + phy-mode = "internal";
> > + };
> > + };
> > + };
> > + };
> > --
> > 2.43.0
Powered by blists - more mailing lists