linux-kernel - Re: [net-next PATCH v2 11/12] net: phy: at803x: move at8035 specific DT parse to dedicated probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35221bc0-4f7d-436d-bfca-a56330682de0@lunn.ch>
Date:   Wed, 6 Dec 2023 18:25:53 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Christian Marangi <ansuelsmth@...il.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH v2 11/12] net: phy: at803x: move at8035 specific
 DT parse to dedicated probe

On Fri, Dec 01, 2023 at 01:14:21AM +0100, Christian Marangi wrote:
> Move at8035 specific DT parse for clock out frequency to dedicated probe
> to make at803x probe function more generic.
> 
> This is to tidy code and no behaviour change are intended.
> 
> Detection logic is changed, we check if the clk 25m mask is set and if
> it's not zero, we assume the qca,clk-out-frequency property is set.
> 
> The property is checked in the generic at803x_parse_dt called by
> at803x_probe.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew