linux-kernel - Re: [PATCH v2 net] net: dsa: microchip: provide a list of valid protocols for xmit handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231206173543.ag7xb4vhcjknyiyv@skbuf>
Date:   Wed, 6 Dec 2023 19:35:43 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Madhuri.Sripada@...rochip.com
Cc:     sean@...nix.com, Woojung.Huh@...rochip.com,
        UNGLinuxDriver@...rochip.com, andrew@...n.ch, f.fainelli@...il.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, Arun.Ramadoss@...rochip.com, ceggers@...i.de,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] net: dsa: microchip: provide a list of valid
 protocols for xmit handler

On Wed, Dec 06, 2023 at 05:22:55PM +0000, Madhuri.Sripada@...rochip.com wrote:
> NULL check is missing here.

Don't just leave it there, also explain why.