linux-kernel - Re: [PATCH v6 0/1] mm: report per-page metadata information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+CK2bARjZgnMBL9bOD7p1u=02-fGgWwfiGvsFVpsJWL-VR2ng@mail.gmail.com>
Date:   Tue, 5 Dec 2023 21:57:36 -0500
From:   Pasha Tatashin <pasha.tatashin@...een.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Sourav Panda <souravpanda@...gle.com>, corbet@....net,
        rafael@...nel.org, akpm@...ux-foundation.org,
        mike.kravetz@...cle.com, muchun.song@...ux.dev, rppt@...nel.org,
        david@...hat.com, rdunlap@...radead.org, chenlinxuan@...ontech.com,
        yang.yang29@....com.cn, tomas.mudrunka@...il.com,
        bhelgaas@...gle.com, ivan@...udflare.com, yosryahmed@...gle.com,
        hannes@...xchg.org, shakeelb@...gle.com,
        kirill.shutemov@...ux.intel.com, wangkefeng.wang@...wei.com,
        adobriyan@...il.com, vbabka@...e.cz, Liam.Howlett@...cle.com,
        surenb@...gle.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-mm@...ck.org, willy@...radead.org, weixugc@...gle.com
Subject: Re: [PATCH v6 0/1] mm: report per-page metadata information

Hi Greg,

Sourav removed the new field from sys/device../nodeN/meminfo as you
requested; however, in nodeN/vmstat fields still get appended, as
there is code that displays every item in zone_stat_item,
node_stat_item without option to opt-out. I mentioned it to you at
LPC.

In my IOMMU [1] series, there are also fields that are added to
node_stat_item that as result are appended to nodeN/vmstat.

Pasha

[1] https://lore.kernel.org/all/20231130201504.2322355-1-pasha.tatashin@soleen.com

On Tue, Dec 5, 2023 at 9:36 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Tue, Dec 05, 2023 at 02:31:17PM -0800, Sourav Panda wrote:
> > Changelog:
> > v6:
> >       - Interface changes
> >               - Added per-node nr_page_metadata and
> >                 nr_page_metadata_boot fields that are exported
> >                 in /sys/devices/system/node/nodeN/vmstat
>
> Again, please do not add any new fields to existing sysfs files, that's
> not going to work well.  You can add a new sysfs file, that's file, but
> do not continue the abuse of the sysfs api in this file.
>
> thanks,
>
> greg k-h