linux-kernel - Re: [PATCH] usb: typec: qcom-pmic: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b2ba3809-81b1-4da7-a441-9ce161a06505@infradead.org>
Date:   Wed, 6 Dec 2023 13:25:53 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Guenter Roeck <linux@...ck-us.net>
Cc:     linux-kernel@...r.kernel.org,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH] usb: typec: qcom-pmic: add CONFIG_OF dependency



On 12/6/23 13:21, Bryan O'Donoghue wrote:
> On 06/12/2023 20:46, Randy Dunlap wrote:
>>
>>
>> On 12/6/23 10:49, Guenter Roeck wrote:
>>> On Wed, Dec 06, 2023 at 09:20:37AM -0800, Randy Dunlap wrote:
>>>> DRM_AUX_BRIDGE depends on CONFIG_OF, so that is also needed here
>>>> to fix a kconfig warning:
>>>>
>>>> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
>>>>    Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
>>>>    Selected by [y]:
>>>>    - TYPEC_QCOM_PMIC [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_TCPM [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
>>>>
>>>
>>> All but impossible for me to determine if this patch or
>>> https://lore.kernel.org/all/20231205-drm_aux_bridge-fixes-v1-2-d242a0ae9df4@kernel.org/
>>> is more appropriate.
>>>
>>> Guenter
>>
>> I guess that Bryan is the person to ask about that.
>>
>> I don't see anything wrong with Nathan's patch. It should clear up the kconfig warning,
>> so as long as it builds cleanly, it seems OK.
>>
> 
> So, I see both versions of this fix
> 
> Nathan's
> drivers/gpu/drm/renesas/rcar-du/Kconfig

No, please see https://lore.kernel.org/all/20231205-drm_aux_bridge-fixes-v1-2-d242a0ae9df4@kernel.org/

> 
> Yours
> drivers/gpu/drm/tve200/Kconfig

No, please see https://lore.kernel.org/linux-usb/a058827a-b025-4ee5-b2a4-d6c8963a6b73@linaro.org/T/#m034fb56a750522f18813642259b18bb4867ceb46

> 
> and virtually equivalent commit text. I think we agree its 1:1
> 
> So, maybe stick with Nathan's since he posted first.

Sure, I'm OK with that.

-- 
~Randy