linux-kernel - fs/bcachefs/extents.c:386:5-8: Unneeded variable: "ret". Return " 0" on line 392

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202312061232.UwWyjKnI-lkp@intel.com>
Date:   Wed, 6 Dec 2023 12:54:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kent Overstreet <kmo@...erainc.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: fs/bcachefs/extents.c:386:5-8: Unneeded variable: "ret". Return "
  0" on line 392

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   bee0e7762ad2c6025b9f5245c040fcc36ef2bde8
commit: b65db750e2bb9252321fd54c284edd73c1595a09 bcachefs: Enumerate fsck errors
date:   5 weeks ago
config: x86_64-randconfig-104-20231204 (https://download.01.org/0day-ci/archive/20231206/202312061232.UwWyjKnI-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20231206/202312061232.UwWyjKnI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312061232.UwWyjKnI-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> fs/bcachefs/extents.c:386:5-8: Unneeded variable: "ret". Return "  0" on line 392
--
>> fs/bcachefs/snapshot.c:37:5-8: Unneeded variable: "ret". Return "  0" on line 44
   fs/bcachefs/snapshot.c:212:5-8: Unneeded variable: "ret". Return "  0" on line 259

vim +386 fs/bcachefs/extents.c

   380	
   381	int bch2_reservation_invalid(struct bch_fs *c, struct bkey_s_c k,
   382				     enum bkey_invalid_flags flags,
   383				     struct printbuf *err)
   384	{
   385		struct bkey_s_c_reservation r = bkey_s_c_to_reservation(k);
 > 386		int ret = 0;
   387	
   388		bkey_fsck_err_on(!r.v->nr_replicas || r.v->nr_replicas > BCH_REPLICAS_MAX, c, err,
   389				 reservation_key_nr_replicas_invalid,
   390				 "invalid nr_replicas (%u)", r.v->nr_replicas);
   391	fsck_err:
 > 392		return ret;
   393	}
   394	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki