linux-kernel - Re: [PATCH v3] usbip: Don't submit special requests twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CXGZGEBGA58J.3CX7BKVV2EUHK@holesch.de>
Date:   Wed, 06 Dec 2023 05:57:37 +0100
From:   "Simon Holesch" <simon@...esch.de>
To:     "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc:     "Valentina Manea" <valentina.manea.m@...il.com>,
        "Shuah Khan" <shuah@...nel.org>, "Hongren Zheng" <i@...ithal.me>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] usbip: Don't submit special requests twice

On Wed Dec 6, 2023 at 4:38 AM CET, Greg Kroah-Hartman wrote:
> On Fri, Dec 01, 2023 at 12:10:13AM +0100, Simon Holesch wrote:
> > -	if (usb_lock_device_for_reset(sdev->udev, NULL) < 0) {
> > +	err = usb_lock_device_for_reset(sdev->udev, NULL)
>
> You didn't actually build this change, so how was it tested?

Last thing I did was update the comment of tweak_special_requests().
Must have hit undo once too often, because I've seen (and fixed) this
error. Really sorry about that. I'll send a v4 with a detailed test
description.

Simon

> {sigh}
>
> greg k-h