linux-kernel - Re: Re: [PATCH bpf-next] netkit: Add some ethtool ops to provide information to user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7053425-65eb-46a0-abd9-59ade5e78211@bytedance.com>
Date:   Wed, 6 Dec 2023 14:59:18 +0800
From:   Feng Zhou <zhoufeng.zf@...edance.com>
To:     Daniel Borkmann <daniel@...earbox.net>,
        Nikolay Aleksandrov <razor@...ckwall.org>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, yangzhenze@...edance.com,
        wangdongdong.6@...edance.com, tangchen.1@...edance.com
Subject: Re: Re: [PATCH bpf-next] netkit: Add some ethtool ops to provide
 information to user

在 2023/12/4 23:22, Daniel Borkmann 写道:
> Thanks, so the netkit_get_link_ksettings is optional. 

Yes, netkit_get_link_ksettings really not necessary, I just added it in 
line with veth.

I don't quite
> follow what you
> mean with regards to your business logic in veth to obtain peer ifindex. 
> What does
> the script do exactly with the peer ifindex (aka /why/ is it needed), 
> could you
> elaborate some more - it's still somewhat too vague? 🙂 E.g. why it does 
> not suffice
> to look at the device type or other kind of attributes?


The scripting logic of the business colleagues should just be simple 
logging records, using ethtool. Then they saw that netkit has this 
missing, so raised this requirement, so I sent this patch, wanting to 
hear your opinions. If you don't think it's necessary, let the business 
colleagues modify it.

Thanks.