linux-kernel - Re: [PATCH v1 1/1] s390: mm: convert pgste locking functions to C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZXBzsCT5vaufHGIZ@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
Date:   Wed, 6 Dec 2023 14:14:24 +0100
From:   Alexander Gordeev <agordeev@...ux.ibm.com>
To:     Heiko Carstens <hca@...ux.ibm.com>
Cc:     Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        borntraeger@...ibm.com, frankja@...ux.ibm.com, nrb@...ux.ibm.com,
        nsg@...ux.ibm.com, svens@...ux.ibm.com, gor@...ux.ibm.com,
        gerald.schaefer@...ux.ibm.com
Subject: Re: [PATCH v1 1/1] s390: mm: convert pgste locking functions to C

On Wed, Dec 06, 2023 at 10:15:41AM +0100, Heiko Carstens wrote:
> On Wed, Dec 06, 2023 at 10:01:18AM +0100, Alexander Gordeev wrote:
> > On Tue, Dec 05, 2023 at 06:32:52PM +0100, Claudio Imbrenda wrote:
> > ...
> > > +	do {
> > > +		value = __atomic64_or_barrier(PGSTE_PCL_BIT, ptr);
> > 
> > Would it make sense to cpu_relax() here, e.g with a follow-up patch?
> 
> No, because cpu_relax() is a no-op on our architecture (besides that it
> translates to barrier(); but __atomic64_or_barrier() obviously comes also
> with barrier() semantics).
> 
> We used to do diag 0x44 with cpu_relax() but that caused many performance
> problems, therefore we removed diag 0x44 completely from the kernel quite
> some time ago.
> 
> See also commit 1b68ac8678a8 ("s390: remove last diag 0x44 caller").

Thanks for the clarification!

Applied.