linux-kernel - Re: [PATCH] i2c: cpm: Fix data type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231206014714.etrj4ecnt4tln5ev@zenone.zhora.eu>
Date:   Wed, 6 Dec 2023 02:47:14 +0100
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     Jochen Friedrich <jochen@...am.de>, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-i2c@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] i2c: cpm: Fix data type

Hi Christophe,

On Tue, Dec 05, 2023 at 07:16:53PM +0100, Christophe Leroy wrote:
> sparse reports an error on some data that gets converted from be32.
> 
> That's because that data is typed u32 instead of __be32.
> 
> Fix it.

the reason for this sparse error is that the data variables is
then parsed with a be32_to_cpup() and I think that's not
necessary.

I think the real fix here is to not use be32_to_cpup().

Andi