linux-kernel - Re: [PATCH for-rc 0/6] Bugfixes and improvements for hns RoCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231206142700.GA18960@unreal>
Date:   Wed, 6 Dec 2023 16:27:00 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Junxian Huang <huangjunxian6@...ilicon.com>
Cc:     jgg@...pe.ca, linux-rdma@...r.kernel.org, linuxarm@...wei.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-rc 0/6] Bugfixes and improvements for hns RoCE

On Tue, Dec 05, 2023 at 10:05:46AM +0800, Junxian Huang wrote:
> 
> 
> On 2023/12/4 22:24, Leon Romanovsky wrote:
> > On Wed, Nov 29, 2023 at 05:44:28PM +0800, Junxian Huang wrote:
> >> Here are several bugfixes and improvements for hns RoCE.
> >>
> >> Chengchang Tang (4):
> >>   RDMA/hns: Rename the interrupts
> >>   RDMA/hns: Remove unnecessary checks for NULL in mtr_alloc_bufs()
> >>   RDMA/hns: Fix memory leak in free_mr_init()
> >>   RDMA/hns: Improve the readability of free mr uninit
> > 
> > 1. The series doesn't apply.
> > ➜  kernel git:(wip/leon-for-next) ~/src/b4/b4.sh shazam -l -s https://lore.kernel.org/all/20231129094434.134528-1-huangjunxian6@hisilicon.com -P 1-5
> 
> Is this series going to be applied to -next?

Yes, I planned to apply them to -next, they don't really important Fixes for -rc4.

> 
> > 2. Please drop patch #6 as you are deleting the code which you added in
> > first patches without actual gain.
> 
> Is it better to drop it directly or merge it with the previous patch?

Please drop.

> 
> Thanks,
> Junxian
> 
> > 
> > Thanks
> > 
> >>
> >> Junxian Huang (2):
> >>   RDMA/hns: Response dmac to userspace
> >>   RDMA/hns: Add a max length of gid table
> >>
> >>  drivers/infiniband/hw/hns/hns_roce_ah.c    |  7 ++
> >>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 87 +++++++++++++++-------
> >>  drivers/infiniband/hw/hns/hns_roce_mr.c    |  2 +-
> >>  include/uapi/rdma/hns-abi.h                |  5 ++
> >>  4 files changed, 73 insertions(+), 28 deletions(-)
> >>
> >> --
> >> 2.30.0
> >>
> >>
> >