linux-kernel - Re: [PATCH v3 1/2] leds: trigger: netdev: extend speeds up to 10G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231207172923.62ce530e@dellmb>
Date:   Thu, 7 Dec 2023 17:29:23 +0100
From:   Marek Behún <kabel@...nel.org>
To:     Daniel Golle <daniel@...rotopia.org>, Lee Jones <lee@...nel.org>,
        Andrew Lunn <andrew@...n.ch>
Cc:     Pavel Machek <pavel@....cz>, Jakub Kicinski <kuba@...nel.org>,
        Christian Marangi <ansuelsmth@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Li Zetao <lizetao1@...wei.com>, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v3 1/2] leds: trigger: netdev: extend speeds up to 10G

On Tue, 28 Nov 2023 04:00:10 +0000
Daniel Golle <daniel@...rotopia.org> wrote:

> Add 2.5G, 5G and 10G as available speeds to the netdev LED trigger.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

So what will happen when there are more speeds? Will we create a
separate file for each speed?

Will we have a separate sysfs file for 10, 100, 1000, 2500, 5000,
10000, 20000, 25000, 40000, 50000, 56000, 100000, 200000, 400000,
800000 ?

These are all speeds from include/uapi/linux/ethtool.h.

Maybe we should have reused ethtool link mode bits, or something...

Also, the files should only be present if the requested speed is
supported by the net device. So if 2500 mbps is not supported, there
should no be link_2500.

Marek