linux-kernel - Re: [PATCH] drm/bridge: samsung-dsim: check the return value only if necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77ee045d-e5e0-4157-ae0d-cd8320a33eb3@kontron.de>
Date:   Thu, 7 Dec 2023 17:42:43 +0100
From:   Frieder Schrempf <frieder.schrempf@...tron.de>
To:     Dario Binacchi <dario.binacchi@...rulasolutions.com>,
        linux-kernel@...r.kernel.org
Cc:     Maxime Ripard <mripard@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Robert Foss <rfoss@...nel.org>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Jonas Karlman <jonas@...boo.se>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        dri-devel@...ts.freedesktop.org,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH] drm/bridge: samsung-dsim: check the return value only if
 necessary

On 07.12.23 17:10, Dario Binacchi wrote:
> It was useless to check again the "ret" variable if the function
> register_host() was not called.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>

Reviewed-by: Frieder Schrempf <frieder.schrempf@...tron.de>

> ---
> 
>  drivers/gpu/drm/bridge/samsung-dsim.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
> index be5914caa17d..98cd589e4427 100644
> --- a/drivers/gpu/drm/bridge/samsung-dsim.c
> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c
> @@ -2020,11 +2020,11 @@ int samsung_dsim_probe(struct platform_device *pdev)
>  	else
>  		dsi->bridge.timings = &samsung_dsim_bridge_timings_de_high;
>  
> -	if (dsi->plat_data->host_ops && dsi->plat_data->host_ops->register_host)
> +	if (dsi->plat_data->host_ops && dsi->plat_data->host_ops->register_host) {
>  		ret = dsi->plat_data->host_ops->register_host(dsi);
> -
> -	if (ret)
> -		goto err_disable_runtime;
> +		if (ret)
> +			goto err_disable_runtime;
> +	}
>  
>  	return 0;
>