linux-kernel - Re: [PATCH 1/2] media: i2c: Add GC08A3 image sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231207-outcome-acclaim-d179c8c07fff@spud>
Date:   Thu, 7 Dec 2023 17:44:32 +0000
From:   Conor Dooley <conor@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Zhi Mao <zhi.mao@...iatek.com>, mchehab@...nel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        shengnan.wang@...iatek.com, yaya.chang@...iatek.com,
        10572168@...com, Project_Global_Chrome_Upstream_Group@...iatek.com,
        yunkec@...omium.org, conor+dt@...nel.org, matthias.bgg@...il.com,
        angelogioacchino.delregno@...labora.com,
        jacopo.mondi@...asonboard.com, hverkuil-cisco@...all.nl,
        heiko@...ech.de, jernej.skrabec@...il.com, macromorgan@...mail.com,
        linus.walleij@...aro.org, laurent.pinchart@...asonboard.com,
        hdegoede@...hat.com, tomi.valkeinen@...asonboard.com,
        gerald.loacker@...fvision.net, andy.shevchenko@...il.com,
        bingbu.cao@...el.com, dan.scally@...asonboard.com,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 1/2] media: i2c: Add GC08A3 image sensor driver

On Thu, Dec 07, 2023 at 01:30:35PM +0100, Krzysztof Kozlowski wrote:
> On 07/12/2023 12:34, Sakari Ailus wrote:
> >> +	ret = gc08a3_parse_fwnode(dev);
> >> +	if (ret)
> >> +		return ret;
> >> +
> >> +	gc08a3 = devm_kzalloc(dev, sizeof(*gc08a3), GFP_KERNEL);
> >> +	if (!gc08a3)
> >> +		return -ENOMEM;
> >> +
> >> +	gc08a3->dev = dev;
> >> +
> >> +	gc08a3->xclk = devm_clk_get(dev, NULL);
> >> +	if (IS_ERR(gc08a3->xclk))
> >> +		return dev_err_probe(dev, PTR_ERR(gc08a3->xclk),
> >> +					 "failed to get xclk\n");
> >> +
> >> +	ret = clk_set_rate(gc08a3->xclk, GC08A3_DEFAULT_CLK_FREQ);
> > 
> > Please see:
> > <URL:https://hverkuil.home.xs4all.nl/spec/driver-api/camera-sensor.html#devicetree>.
> 
> 
> Oh, that's cool it was documented!
> 
> The canonical link would be:
> https://www.kernel.org/doc/html/latest/driver-api/media/camera-sensor.html#devicetree

I believe this is that answer to the "why are these needed" that I asked
on the previous version and never got a response to. Instead, they were
just removed from the binding etc.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)