linux-kernel - RE: [EXT] [PATCH] ethernet: atheros: fix a memleak in atl1e_setup_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR18MB5216F502703DA2B49B013BC7DB8BA@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date:   Thu, 7 Dec 2023 17:54:44 +0000
From:   Suman Ghosh <sumang@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Zhipeng Lu <alexious@....edu.cn>,
        Chris Snook <chris.snook@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Simon Horman <horms@...nel.org>,
        Yuanjun Gong <ruc_gongyuanjun@....com>,
        Jie Yang <jie.yang@...eros.com>,
        Jeff Garzik <jgarzik@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH] ethernet: atheros: fix a memleak in
 atl1e_setup_ring_resources

>On Thu, 7 Dec 2023 17:08:15 +0000 Suman Ghosh wrote:
>> >+		kfree(tx_ring->tx_buffer);
>>
>> [Suman] I think we should do tx_ring->tx_buffer = NULL also, to avoid
>use after free?
>
>It's up to the driver. Some may call that defensive programming.
[Suman] Agree. I pointed it out since this driver is using this approach at other places. But sure, it is up to Zhipeng.