linux-kernel - Re: [PATCH] ocxl: fix driver function comment typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu,  7 Dec 2023 09:43:07 +0800
From:   jiangyunshui <jiangyunshui@...inos.cn>
To:     christophe.leroy@...roup.eu
Cc:     ajd@...ux.ibm.com, fbarrat@...ux.ibm.com, jiangyunshui@...inos.cn,
        kernel-bot@...inos.cn, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] ocxl: fix driver function comment typo

> Date: Tue, 5 Dec 2023 11:00:16 +0000	[thread overview]
> Message-ID: <2f2aca95-f5a6-45fa-9e3b-37aecf657299@...roup.eu> (raw)
> In-Reply-To: <20231205094319.32114-1-jiangyunshui@...inos.cn>

> Please add a description explaining why you want to do that change.

> When I grep I see cxlflash driver, I don't know what ocxlflash driver is:

> $ git grep ocxl_config_read_afu
> ...
> drivers/scsi/cxlflash/ocxl_hw.c:        rc = ocxl_config_read_afu(pdev, 
> fcfg, acfg, 0);
> drivers/scsi/cxlflash/ocxl_hw.c:                dev_err(dev, "%s: 
> ocxl_config_read_afu failed rc=%d\n",
> include/misc/ocxl.h:int ocxl_config_read_afu(struct pci_dev *dev,

> Christophe

I checked my commit again and found I'd mismatched the driver's name with other things.
As you said it doesn't make sense to change cxlflash to ocxlflash.
Sorry for the inconvenience, you could just drop my commit please.
Thanks,

Yunshui

> ---
> Reported-by: k2ci <kernel-bot@...inos.cn>
> Signed-off-by: yunshui <jiangyunshui@...inos.cn>
> ---
>   include/misc/ocxl.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/misc/ocxl.h b/include/misc/ocxl.h
> index 3ed736da02c8..ef7d26009a36 100644
> --- a/include/misc/ocxl.h
> +++ b/include/misc/ocxl.h
> @@ -324,7 +324,7 @@ int ocxl_global_mmio_clear32(struct ocxl_afu *afu, size_t offset,
>   int ocxl_global_mmio_clear64(struct ocxl_afu *afu, size_t offset,
>                               enum ocxl_endian endian, u64 mask);
>
> -// Functions left here are for compatibility with the cxlflash driver
> +// Functions left here are for compatibility with the ocxlflash driver
>
>   /*
>    * Read the configuration space of a function for the AFU specified by
> --
> 2.25.1
>