linux-kernel - Re: [PATCH] media: chips-media: wave5: remove duplicate check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81903c6258fe21696775a290e338cc2042a7ff64.camel@ndufresne.ca>
Date:   Thu, 07 Dec 2023 14:08:26 -0500
From:   Nicolas Dufresne <nicolas@...fresne.ca>
To:     Dan Carpenter <dan.carpenter@...aro.org>,
        Nas Chung <nas.chung@...psnmedia.com>
Cc:     Jackson Lee <jackson.lee@...psnmedia.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] media: chips-media: wave5: remove duplicate check

Le mardi 28 novembre 2023 à 17:39 +0300, Dan Carpenter a écrit :
> We already verified that "ret" is zero a few lines earlier.  Delete this
> duplicate check.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

> ---
>  drivers/media/platform/chips-media/wave5/wave5-hw.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
> index 3fcb2d92add8..f1e022fb148e 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
> @@ -578,9 +578,6 @@ int wave5_vpu_dec_init_seq(struct vpu_instance *inst)
>  	dev_dbg(inst->dev->dev, "%s: init seq sent (queue %u : %u)\n", __func__,
>  		p_dec_info->instance_queue_count, p_dec_info->report_queue_count);
>  
> -	if (ret)
> -		return ret;
> -
>  	return 0;
>  }
>