linux-kernel - Re: [PATCH v2 1/2] Input: i8042: Avoid probing if no keyboard and mouse are set in quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7296e7c-8920-4bd7-b2a8-c5dc6ffdee03@amd.com>
Date:   Thu, 7 Dec 2023 14:39:58 -0600
From:   Mario Limonciello <mario.limonciello@....com>
To:     Rahul Rameshbabu <rrameshbabu@...dia.com>
Cc:     dmitry.torokhov@...il.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] Input: i8042: Avoid probing if no keyboard and
 mouse are set in quirks

On 12/6/2023 15:55, Rahul Rameshbabu wrote:
> On Wed, 06 Dec, 2023 15:21:39 -0600 Mario Limonciello <mario.limonciello@....com> wrote:
>> Some laptops have an i8042 controller in the SOC, nothing mentioned in
>> ACPI PNP and nothing connected to the controller. Add the ability to
>> skip probing in this case.
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
>> ---
> 
> Thanks. I think this is a good choice for handling the issue you
> presented with the Framework 16.
> 
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@...dia.com>

Thanks!

Dmitry,

Are you OK with this?  The other direction I considered was to add a DMI 
BIOS year check and "only continue to probe" non PNP devices on systems 
older than 2023.

That could let you cut and run without needing to continue to add quirks 
like this but it could be riskier.