linux-kernel - Re: [PATCH] vdpa: Fix an error handling path in eni_vdpa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72a89724-9dad-499a-a0ed-ad9d046d235d@wanadoo.fr>
Date:   Thu, 7 Dec 2023 22:13:51 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Wu Zongyong <wuzongyong@...ux.alibaba.com>,
        Arnd Bergmann <arnd@...db.de>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] vdpa: Fix an error handling path in eni_vdpa_probe()

Le 20/10/2022 à 21:21, Christophe JAILLET a écrit :
> After a successful vp_legacy_probe() call, vp_legacy_remove() should be
> called in the error handling path, as already done in the remove function.
> 
> Add the missing call.
> 
> Fixes: e85087beedca ("eni_vdpa: add vDPA driver for Alibaba ENI")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/vdpa/alibaba/eni_vdpa.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vdpa/alibaba/eni_vdpa.c b/drivers/vdpa/alibaba/eni_vdpa.c
> index 5a09a09cca70..cce3d1837104 100644
> --- a/drivers/vdpa/alibaba/eni_vdpa.c
> +++ b/drivers/vdpa/alibaba/eni_vdpa.c
> @@ -497,7 +497,7 @@ static int eni_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   	if (!eni_vdpa->vring) {
>   		ret = -ENOMEM;
>   		ENI_ERR(pdev, "failed to allocate virtqueues\n");
> -		goto err;
> +		goto err_remove_vp_legacy;
>   	}
>   
>   	for (i = 0; i < eni_vdpa->queues; i++) {
> @@ -509,11 +509,13 @@ static int eni_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   	ret = vdpa_register_device(&eni_vdpa->vdpa, eni_vdpa->queues);
>   	if (ret) {
>   		ENI_ERR(pdev, "failed to register to vdpa bus\n");
> -		goto err;
> +		goto err_remove_vp_legacy;
>   	}
>   
>   	return 0;
>   
> +err_remove_vp_legacy:
> +	vp_legacy_remove(&eni_vdpa->ldev);
>   err:
>   	put_device(&eni_vdpa->vdpa.dev);
>   	return ret;

Polite reminder on a (very) old patch.

CJ