linux-kernel - Re: [PATCH] usb: cdns3: starfive: don't misuse /** comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL411-rcnuJtNJnvpkq4KWMib7xP08SEH8c5F1eT2mgZi4H6ng@mail.gmail.com>
Date:   Thu, 7 Dec 2023 11:00:22 +0800
From:   Peter Chen <hzpeterchen@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Minda Chen <minda.chen@...rfivetech.com>,
        Peter Chen <peter.chen@...nel.org>,
        Pawel Laszczak <pawell@...ence.com>,
        Roger Quadros <rogerq@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: cdns3: starfive: don't misuse /** comment

On Thu, Dec 7, 2023 at 2:13 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Use a common C comment "/*" instead of "/**" to prevent a warning
> from scripts/kernel-doc.
>
> cdns3-starfive.c:23: warning: expecting prototype for cdns3(). Prototype was for USB_STRAP_HOST() instead
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Minda Chen <minda.chen@...rfivetech.com>
> Cc: Peter Chen <peter.chen@...nel.org>
> Cc: Pawel Laszczak <pawell@...ence.com>
> Cc: Roger Quadros <rogerq@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-usb@...r.kernel.org
> ---

Acked-by: Peter Chen <peter.chen@...nel.org>

Peter


>  drivers/usb/cdns3/cdns3-starfive.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/usb/cdns3/cdns3-starfive.c b/drivers/usb/cdns3/cdns3-starfive.c
> --- a/drivers/usb/cdns3/cdns3-starfive.c
> +++ b/drivers/usb/cdns3/cdns3-starfive.c
> @@ -1,5 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0
> -/**
> +/*
>   * cdns3-starfive.c - StarFive specific Glue layer for Cadence USB Controller
>   *
>   * Copyright (C) 2023 StarFive Technology Co., Ltd.