linux-kernel - [PATCH] x86/mm: Remove unnecessary logic from numa_cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20231207041841.205818-1-ytcoode@gmail.com>
Date:   Thu,  7 Dec 2023 12:18:41 +0800
From:   Yuntao Wang <ytcoode@...il.com>
To:     linux-kernel@...r.kernel.org, x86@...nel.org
Cc:     Dave Hansen <dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, Yuntao Wang <ytcoode@...il.com>
Subject: [PATCH] x86/mm: Remove unnecessary logic from numa_cleanup_meminfo()

The `bi->start` field is of type u64, which can only hold values greater
than or equal to 0. Therefore, the logic `bi->start = max(bi->start, low)`
is unnecessary. Remove it.

Signed-off-by: Yuntao Wang <ytcoode@...il.com>
---
 arch/x86/mm/numa.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
index b29ceb19e46e..f7336077b07e 100644
--- a/arch/x86/mm/numa.c
+++ b/arch/x86/mm/numa.c
@@ -239,7 +239,6 @@ static void __init alloc_node_data(int nid)
  */
 int __init numa_cleanup_meminfo(struct numa_meminfo *mi)
 {
-	const u64 low = 0;
 	const u64 high = PFN_PHYS(max_pfn);
 	int i, j, k;
 
@@ -254,9 +253,6 @@ int __init numa_cleanup_meminfo(struct numa_meminfo *mi)
 			continue;
 		}
 
-		/* make sure all non-reserved blocks are inside the limits */
-		bi->start = max(bi->start, low);
-
 		/* preserve info for non-RAM areas above 'max_pfn': */
 		if (bi->end > high) {
 			numa_add_memblk_to(bi->nid, high, bi->end,
-- 
2.43.0