linux-kernel - Re: [PATCH v5 8/8] LoongArch: Add ORC stack unwinder support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5f383dd-a8d9-114a-3172-f4ef7539a106@loongson.cn>
Date:   Thu, 7 Dec 2023 15:08:48 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Huacai Chen <chenhuacai@...nel.org>
Cc:     Josh Poimboeuf <jpoimboe@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 8/8] LoongArch: Add ORC stack unwinder support



On 12/02/2023 09:45 PM, Huacai Chen wrote:
> Hi, Tiezhu,
>
> On Wed, Nov 29, 2023 at 9:07 PM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>>
>> The kernel CONFIG_UNWINDER_ORC option enables the ORC unwinder, which is
>> similar in concept to a DWARF unwinder. The difference is that the format
>> of the ORC data is much simpler than DWARF, which in turn allows the ORC
>> unwinder to be much simpler and faster.

...

>> diff --git a/arch/loongarch/kernel/lbt.S b/arch/loongarch/kernel/lbt.S
>> index 9c75120a26d8..4d6914f84c7e 100644
>> --- a/arch/loongarch/kernel/lbt.S
>> +++ b/arch/loongarch/kernel/lbt.S
>> @@ -11,6 +11,7 @@
>>  #include <asm/asm-offsets.h>
>>  #include <asm/errno.h>
>>  #include <asm/regdef.h>
>> +#include <asm/unwind_hints.h>
>>
>>  #define SCR_REG_WIDTH 8
>>
>> @@ -153,3 +154,7 @@ SYM_FUNC_END(_restore_ftop_context)
>>  .L_lbt_fault:
>>         li.w            a0, -EFAULT             # failure
>>         jr              ra
>> +
>> +#ifdef CONFIG_CPU_HAS_LBT
>> +STACK_FRAME_NON_STANDARD _restore_ftop_context
>> +#endif
> This file is only compiled if CONFIG_CPU_HAS_LBT is set, so #ifdef can
> be removed.

OK, will remove it in the next version.

Thanks,
Tiezhu