linux-kernel - Re: [PATCH] irqchip/gic-v3-its: BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87edfy8nlj.wl-maz@kernel.org>
Date:   Thu, 07 Dec 2023 07:43:04 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Mukesh Ojha <quic_mojha@...cinc.com>
Cc:     <tglx@...utronix.de>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] irqchip/gic-v3-its: BUG_ON if stall bit is set

On Thu, 07 Dec 2023 06:12:39 +0000,
Mukesh Ojha <quic_mojha@...cinc.com> wrote:
> 
> There could be various reason that stall bit could
> be set due to software errors while processing
> commands in command queue is being processed and

Such as?

> waiting for 1s is not going to help in debugging
> as command processing anyways going to be timed
> out and system will continue to run and may crash
> after some time due to this.
> 
> So, to debug such issues what command caused the
> stall bit to set, BUG_ON right away.

How on Earth will killing the system allow *anything* to be further
debugged?

If you need debug information, add the correct debug statements using
pr_debug(). Even better, try to gracefully recover from it if the ITS
command queue supports restarting.

Crashing the system is not an option.

	M.

-- 
Without deviation from the norm, progress is not possible.