linux-kernel - RE: [PATCH v3 RESEND 1/4] phy: core: add notify_connect and notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <922b768b3be4404a88a906cddebdc8df@realtek.com>
Date:   Thu, 7 Dec 2023 09:34:36 +0000
From:   Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>
To:     Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Vinod Koul <vkoul@...nel.org>, Johan Hovold <johan@...nel.org>,
        "Kishon Vijay Abraham I" <kishon@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Jinjie Ruan <ruanjinjie@...wei.com>,
        Rob Herring <robh@...nel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Flavio Suligoi <f.suligoi@...m.it>,
        Ricardo Cañuelo 
        <ricardo.canuelo@...labora.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH v3 RESEND 1/4] phy: core: add notify_connect and notify_disconnect callback

Hi Sergei,

> 
> 
> On 12/7/23 10:38 AM, Stanley Chang wrote:
> 
> > In Realtek SoC, the parameter of usb phy is designed to can dynamic
> > tuning base on port status. Therefore, add a notify callback of phy
> 
>    To be able to do dynamic tuning based in the port status, maybe?

Okay, I will revise.

> > driver when usb connection/disconnection change.


> > Signed-off-by: Stanley Chang <stanley_chang@...ltek.com>
> [...]
> > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index
> > 96a0b1e111f3..a84ad4896b7f 100644
> > --- a/drivers/phy/phy-core.c
> > +++ b/drivers/phy/phy-core.c
> > @@ -489,6 +489,53 @@ int phy_calibrate(struct phy *phy)  }
> > EXPORT_SYMBOL_GPL(phy_calibrate);
> >
> > +/**
> > + * phy_notify_connect() - phy connect notify
> 
>    Notification?

Okay, I will revise.

> > + * @phy: the phy returned by phy_get()
> > + * @port: the port index for connect
> > + *
> > + * If phy need the get connection status, the callback can be used.
> 
>    If the PHY needs to get the connection status, maybe?
> 
> > + * Returns: %0 if successful, a negative error code otherwise  */ int
> > +phy_notify_connect(struct phy *phy, int port) {
> > +     int ret;
> > +
> > +     if (!phy || !phy->ops->connect)
> > +             return 0;
> > +
> > +     mutex_lock(&phy->mutex);
> > +     ret = phy->ops->connect(phy, port);
> > +     mutex_unlock(&phy->mutex);
> > +
> > +     return ret;
> > +}
> > +EXPORT_SYMBOL_GPL(phy_notify_connect);
> > +
> > +/**
> > + * phy_notify_disconnect() - phy disconnect notify
> 
>    Notification?

Okay, I will revise.

> > + * @phy: the phy returned by phy_get()
> > + * @port: the port index for disconnect
> > + *
> > + * If phy need the get disconnection status, the callback can be used.
> 
>    If the PHY needs to get the connection status, maybe?

Okay, I will revise.

Thanks,
Stanley