linux-kernel - Re: [PATCH RFC 02/39] mm/rmap: introduce and use hugetlb_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76fd4d99-e7b5-4fdc-8864-af4a198e9981@intel.com>
Date:   Thu, 7 Dec 2023 08:56:23 +0800
From:   Yin Fengwei <fengwei.yin@...el.com>
To:     David Hildenbrand <david@...hat.com>,
        <linux-kernel@...r.kernel.org>
CC:     <linux-mm@...ck.org>, Andrew Morton <akpm@...ux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Hugh Dickins <hughd@...gle.com>,
        Ryan Roberts <ryan.roberts@....com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Muchun Song <muchun.song@...ux.dev>,
        Peter Xu <peterx@...hat.com>
Subject: Re: [PATCH RFC 02/39] mm/rmap: introduce and use
 hugetlb_remove_rmap()



On 12/6/23 20:11, David Hildenbrand wrote:
> On 06.12.23 02:22, Yin Fengwei wrote:
>>
>>
>> On 12/4/23 22:21, David Hildenbrand wrote:
>>> hugetlb rmap handling differs quite a lot from "ordinary" rmap code.
>>> For example, hugetlb currently only supports entire mappings, and treats
>>> any mapping as mapped using a single "logical PTE". Let's move it out
>>> of the way so we can overhaul our "ordinary" rmap.
>>> implementation/interface.
>>>
>>> Let's introduce and use hugetlb_remove_rmap() and remove the hugetlb
>>> code from page_remove_rmap(). This effectively removes one check on the
>>> small-folio path as well.
>>>
>>> Note: all possible candidates that need care are page_remove_rmap() that
>>>        pass compound=true.
>>>
>>> Signed-off-by: David Hildenbrand <david@...hat.com>
>>
>>
> 
> I suspect you wanted to place your RB tag here? :)
Oops. Yes. I meant my RB tag here.


Regards
Yin, Fengwei