linux-kernel - Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXGzJlv9C3Z9lMeI@kuha.fi.intel.com>
Date:   Thu, 7 Dec 2023 13:57:26 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     Arnd Bergmann <arnd@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency

On Thu, Dec 07, 2023 at 01:55:06PM +0200, Dmitry Baryshkov wrote:
> On Thu, 7 Dec 2023 at 13:53, Heikki Krogerus
> <heikki.krogerus@...ux.intel.com> wrote:
> >
> > On Wed, Dec 06, 2023 at 01:38:14PM +0100, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@...db.de>
> > >
> > > DRM_AUX_BRIDGE depends on CONFIG_OF, so the same dependency is needed
> > > here to avoid a build failure:
> > >
> > > WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE
> > >   Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
> > >   Selected by [y]:
> > >   - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
> > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_register':
> > > aux-bridge.c:(.text+0x13b): undefined reference to `auxiliary_device_init'
> > > x86_64-linux-ld: aux-bridge.c:(.text+0x14d): undefined reference to `__auxiliary_device_add'
> > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_init':
> > > aux-bridge.c:(.init.text+0x15): undefined reference to `__auxiliary_driver_register'
> > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_exit':
> > > aux-bridge.c:(.exit.text+0x9): undefined reference to `auxiliary_driver_unregister'
> > >
> > > Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE")
> > > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > > ---
> > >  drivers/usb/typec/mux/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
> > > index 5120942f309d..818624f59120 100644
> > > --- a/drivers/usb/typec/mux/Kconfig
> > > +++ b/drivers/usb/typec/mux/Kconfig
> > > @@ -40,6 +40,7 @@ config TYPEC_MUX_NB7VPQ904M
> > >       tristate "On Semiconductor NB7VPQ904M Type-C redriver driver"
> > >       depends on I2C
> > >       depends on DRM || DRM=n
> > > +     depends on OF
> > >       select DRM_AUX_BRIDGE if DRM_BRIDGE
> > >       select REGMAP_I2C
> > >       help
> >
> > Shouldn't DRM_BRIDGE depend on OF instead?
> 
> No. DRM_AUX_BRIDGE depends on OF, DRM_BRIDGE framework doesn't.

Okay, so this probable should also be

        select DRM_AUX_BRIDGE if DRM_BRIDGE and OF

No?

thanks,

-- 
heikki