linux-kernel - Re: [PATCH V4] scsi: ufs: core: store min and max clk freq from OPP table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf2b1671-2911-4d74-abfb-e6dbfe03d626@acm.org>
Date:   Wed, 6 Dec 2023 15:06:14 -1000
From:   Bart Van Assche <bvanassche@....org>
To:     Nitin Rawat <quic_nitirawa@...cinc.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_cang@...cinc.com, Manish Pandey <quic_mapa@...cinc.com>
Subject: Re: [PATCH V4] scsi: ufs: core: store min and max clk freq from OPP
 table

On 12/6/23 03:38, Nitin Rawat wrote:
> +	list_for_each_entry(clki, head, list) {
> +		if (!clki->name)
> +			continue;
> +
> +		clki->clk = devm_clk_get(hba->dev, clki->name);
> +		if (!IS_ERR(clki->clk)) {

Please change the above line into the following:

	if (IS_ERR(...))
		continue;

to reduce the indentation level of the code below this statement.

Thanks,

Bart.