linux-kernel - Re: [PATCH] freezer,sched: Move state information judgment outside task_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231207123545.GB36716@noisy.programming.kicks-ass.net>
Date:   Thu, 7 Dec 2023 13:35:45 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Xiaolei Wang <xiaolei.wang@...driver.com>
Cc:     rafael@...nel.org, pavel@....cz, len.brown@...el.com,
        mingo@...nel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] freezer,sched: Move state information judgment outside
 task_call_func

On Thu, Dec 07, 2023 at 07:16:34PM +0800, Xiaolei Wang wrote:
> It is dangerous to output warnings in task_call_func,
> which may lead to the risk of deadlock. task_call_func
> uses p->pi_lock, and the serial port output may call
> try_to_wake_up to wake up the write buff, which also
> uses p->pi_lock.

No, we're not going to make the code ugly because printk is stupid. Fix
whatever that triggers the WARN and leave it at that.