linux-kernel - Re: [PATCH] media: dt-bindings: ov8856: add missing second link frequency in example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a5019f2-6b32-4960-b494-50434d7659f0@linaro.org>
Date:   Thu, 7 Dec 2023 14:59:22 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dt-bindings: ov8856: add missing second link
 frequency in example

On 05/12/2023 12:43, Sakari Ailus wrote:
> On Tue, Dec 05, 2023 at 11:01:41AM +0000, Sakari Ailus wrote:
>> Hi Krzysztof,
>>
>> Thanks for the patch.
>>
>> On Tue, Dec 05, 2023 at 09:48:35AM +0100, Krzysztof Kozlowski wrote:
>>> Bindings and Linux driver require two link frequencies, so correct the
>>> example:
>>>
>>>   ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short
>>>
>>> Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas")
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> ---
>>>  Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
>>> index 57f5e48fd8e0..bd1a55d767e7 100644
>>> --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
>>> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
>>> @@ -126,7 +126,7 @@ examples:
>>>                  wcam_out: endpoint {
>>>                      remote-endpoint = <&mipi_in_wcam>;
>>>                      data-lanes = <1 2 3 4>;
>>> -                    link-frequencies = /bits/ 64 <360000000>;
>>> +                    link-frequencies = /bits/ 64 <360000000 180000000>;
>>
>> There indeed seems to be a problem with the example as far as the bindings
>> are concerned but the primary issue seems to be in the bindings. Both of
>> these frequencies have significance from driver point of view only while
>> the device itself supports a (wider) range.
>>
>> How about removing maxItems and items from the bindings instead?
> 
> There's also a similar issue with lanes: 1, 2 and 4 are supported.

ack

Best regards,
Krzysztof