linux-kernel - Re: [PATCH 2/2] bus: moxtet: Add spi device table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Dec 2023 15:09:35 +0100
From:   Marek Behún <kabel@...nel.org>
To:     Sjoerd Simons <sjoerd@...labora.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] bus: moxtet: Add spi device table

On Thu, 23 Nov 2023 15:23:38 +0100
Sjoerd Simons <sjoerd@...labora.com> wrote:

> The moxtet module was failing to auto-load on my system. Add a SPI id
> table to allow it to do so.
> 
> Signed-off-by: Sjoerd Simons <sjoerd@...labora.com>
> 
> ---
> 
>  drivers/bus/moxtet.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c
> index 48c18f95660a..e384fbc6c1d9 100644
> --- a/drivers/bus/moxtet.c
> +++ b/drivers/bus/moxtet.c
> @@ -830,6 +830,12 @@ static void moxtet_remove(struct spi_device *spi)
>  	mutex_destroy(&moxtet->lock);
>  }
>  
> +static const struct spi_device_id moxtet_spi_ids[] = {
> +	{ "moxtet" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(spi, moxtet_spi_ids);
> +
>  static const struct of_device_id moxtet_dt_ids[] = {
>  	{ .compatible = "cznic,moxtet" },
>  	{},
> @@ -841,6 +847,7 @@ static struct spi_driver moxtet_spi_driver = {
>  		.name		= "moxtet",
>  		.of_match_table = moxtet_dt_ids,
>  	},
> +	.id_table	= moxtet_spi_ids,
>  	.probe		= moxtet_probe,
>  	.remove		= moxtet_remove,
>  };

Reviewed-by: Marek Behún <kabel@...nel.org>