linux-kernel - Re: [PATCH 00/16] ALSA: hda/tas2781: Add tas2563 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 07 Dec 2023 15:38:37 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Mark Brown <broonie@...nel.org>
Cc:     Gergo Koteles <soyer@....hu>, Shenghao Ding <shenghao-ding@...com>,
        Kevin Lu <kevin-lu@...com>, Baojun Xu <baojun.xu@...com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH 00/16] ALSA: hda/tas2781: Add tas2563 support

On Thu, 07 Dec 2023 14:55:25 +0100,
Mark Brown wrote:
> 
> On Thu, Dec 07, 2023 at 01:58:22AM +0100, Gergo Koteles wrote:
> 
> > Gergo Koteles (16):
> >   ASoC: tas2781: add support for fw version 0x0503
> >   ALSA: hda/tas2781: leave hda_component in usable state
> >   ASoC: tas2781: disable regmap regcache
> >   ALSA: hda/tas2781: handle missing calibration data
> >   ALSA: hda/tas2781: fix typos in comment
> >   ASoC: tas2781: add ptrs to calibration functions
> >   ALSA: hda/tas2781: load_calibration just load
> >   ASoC: tas2781: add configurable global_addr
> >   ALSA: hda/tas2781: add TAS2563 support for 14ARB7
> >   ASoC: tas2781: check negative indexes
> >   ASoC: tas2781: use 0 as default prog/conf index
> >   ASoC: tas2781: move set_drv_data outside tasdevice_init
> >   ALSA: hda/tas2781: remove sound controls in unbind
> >   ALSA: hda/tas2781: call cleaner functions only once
> >   ALSA: hda/tas2781: reset the amp before component_add
> >   ALSA: hda/tas2781: configure the amp after firmware load
> 
> Please don't randomly interleave ASoC and ALSA patches like this without
> some strong need, it just makes everything harder to manage.

And, some look really like rather individual fixes; they deserve for
Fixes tag and Cc-to-stable, at least.


thanks,

Takashi